mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 02/18] x86 vDSO: use vdso-syms.lds
Date: Mon, 19 Nov 2007 14:02:06 -0800 (PST)	[thread overview]
Message-ID: <20071119220206.4CE4D26F8BE@magilla.localdomain> (raw)
In-Reply-To: Roland McGrath's message of  Monday, 19 November 2007 13:59:43 -0800 <20071119215944.01B7C26F8BE@magilla.localdomain>


This patch changes the kernel's references to addresses in the vDSO image
to be based on the symbols defined by vdso-syms.lds instead of the old
vdso-syms.o symbols.  This is all wrapped up in a macro defined by the new
asm-x86/vdso.h header; that's the only place in the kernel source that has
to know the details of the scheme for getting vDSO symbol values.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 arch/x86/vdso/Makefile     |    3 +--
 arch/x86/vdso/vdso-start.S |    2 --
 arch/x86/vdso/vma.c        |   18 +++++++-----------
 include/asm-x86/vdso.h     |   14 ++++++++++++++
 4 files changed, 22 insertions(+), 15 deletions(-)
 delete mode 100644 arch/x86/vdso/vdso-start.S
 create mode 100644 include/asm-x86/vdso.h

diff --git a/arch/x86/vdso/Makefile b/arch/x86/vdso/Makefile
index d8200ad..d2ec170 100644
--- a/arch/x86/vdso/Makefile
+++ b/arch/x86/vdso/Makefile
@@ -3,8 +3,7 @@
 #
 
 # files to link into the vdso
-# vdso-start.o has to be first
-vobjs-y := vdso-start.o vdso-note.o vclock_gettime.o vgetcpu.o vvar.o
+vobjs-y := vdso-note.o vclock_gettime.o vgetcpu.o vvar.o
 
 # files to link into kernel
 obj-y := vma.o vdso.o vdso-syms.o
diff --git a/arch/x86/vdso/vdso-start.S b/arch/x86/vdso/vdso-start.S
deleted file mode 100644
index 2dc2cdb..0000000
--- a/arch/x86/vdso/vdso-start.S
+++ /dev/null
@@ -1,2 +0,0 @@
-	.globl vdso_kernel_start
-vdso_kernel_start:
diff --git a/arch/x86/vdso/vma.c b/arch/x86/vdso/vma.c
index ff9333e..3fdd514 100644
--- a/arch/x86/vdso/vma.c
+++ b/arch/x86/vdso/vma.c
@@ -11,23 +11,20 @@
 #include <asm/vsyscall.h>
 #include <asm/vgtod.h>
 #include <asm/proto.h>
-#include "voffset.h"
+#include <asm/vdso.h>
 
-int vdso_enabled = 1;
-
-#define VEXTERN(x) extern typeof(__ ## x) *vdso_ ## x;
-#include "vextern.h"
+#include "vextern.h"		/* Just for VMAGIC.  */
 #undef VEXTERN
 
-extern char vdso_kernel_start[], vdso_start[], vdso_end[];
+int vdso_enabled = 1;
+
+extern char vdso_start[], vdso_end[];
 extern unsigned short vdso_sync_cpuid;
 
 struct page **vdso_pages;
 
-static inline void *var_ref(void *vbase, char *var, char *name)
+static inline void *var_ref(void *p, char *name)
 {
-	unsigned offset = var - &vdso_kernel_start[0] + VDSO_TEXT_OFFSET;
-	void *p = vbase + offset;
 	if (*(void **)p != (void *)VMAGIC) {
 		printk("VDSO: variable %s broken\n", name);
 		vdso_enabled = 0;
@@ -62,9 +59,8 @@ static int __init init_vdso_vars(void)
 		vdso_enabled = 0;
 	}
 
-#define V(x) *(typeof(x) *) var_ref(vbase, (char *)RELOC_HIDE(&x, 0), #x)
 #define VEXTERN(x) \
-	V(vdso_ ## x) = &__ ## x;
+	*(typeof(__ ## x) **) var_ref(VDSO64_SYMBOL(vbase, x), #x) = &__ ## x;
 #include "vextern.h"
 #undef VEXTERN
 	return 0;
diff --git a/include/asm-x86/vdso.h b/include/asm-x86/vdso.h
new file mode 100644
index 0000000..9379ec0
--- /dev/null
+++ b/include/asm-x86/vdso.h
@@ -0,0 +1,14 @@
+#ifndef _ASM_X86_VDSO_H
+#define _ASM_X86_VDSO_H	1
+
+extern const char VDSO64_PRELINK[];
+
+/*
+ * Given a pointer to the vDSO image, find the pointer to VDSO64_name
+ * as that symbol is defined in the vDSO sources or linker script.
+ */
+#define VDSO64_SYMBOL(base, name) ({		\
+	extern const char VDSO64_##name[];	\
+	(void *) (VDSO64_##name - VDSO64_PRELINK + (unsigned long) (base)); })
+
+#endif	/* asm-x86/vdso.h */

  parent reply	other threads:[~2007-11-19 22:02 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-19 21:59 [PATCH 00/18] x86 vDSO revamp Roland McGrath
2007-11-19 22:01 ` [PATCH 01/18] x86 vDSO: generate vdso-syms.lds Roland McGrath
2007-11-19 22:02 ` Roland McGrath [this message]
2007-11-19 22:02 ` [PATCH 03/18] x86 vDSO: remove vdso-syms.o Roland McGrath
2007-11-19 22:03 ` [PATCH 04/18] x86 vDSO: new layout Roland McGrath
2007-11-19 22:03 ` [PATCH 05/18] x86 vDSO: harmonize asm-offsets Roland McGrath
2007-11-19 22:04 ` [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32 Roland McGrath
2007-11-20 13:05   ` Thomas Gleixner
2007-11-20 20:57     ` Roland McGrath
2007-11-20 23:07       ` Thomas Gleixner
2007-11-20 23:27         ` Roland McGrath
2007-11-20 23:50           ` Thomas Gleixner
2007-11-27  1:53           ` Linus Torvalds
2007-11-27  2:01             ` Roland McGrath
2007-11-19 22:05 ` [PATCH 07/18] x86 vDSO: vdso32 build Roland McGrath
2007-11-21  6:02   ` Sam Ravnborg
2007-11-21  7:10     ` Roland McGrath
2007-11-21  7:32       ` Sam Ravnborg
2007-11-21  7:55         ` Roland McGrath
2007-11-19 22:05 ` [PATCH 08/18] x86 vDSO: i386 vdso32 Roland McGrath
2007-11-19 22:05 ` [PATCH 09/18] x86 vDSO: absolute relocs Roland McGrath
2007-11-19 22:05 ` [PATCH 10/18] x86 vDSO: i386 vdso32 install Roland McGrath
2007-11-19 22:06 ` [PATCH 11/18] x86 vDSO: vdso32 setup Roland McGrath
2007-11-19 22:06 ` [PATCH 12/18] x86 vDSO: ia32_sysenter_target Roland McGrath
2007-11-19 22:06 ` [PATCH 13/18] x86 vDSO: ia32 sysenter_return Roland McGrath
2007-11-21  0:05   ` Zachary Amsden
2007-11-21  0:34     ` Roland McGrath
2007-11-19 22:06 ` [PATCH 14/18] x86 vDSO: ia32 vdso32-syscall build Roland McGrath
2007-11-19 22:06 ` [PATCH 15/18] x86 vDSO: consolidate vdso32 Roland McGrath
2007-11-21  0:13   ` Zachary Amsden
2007-11-21  0:13     ` Ingo Molnar
2007-11-21  0:15     ` Andi Kleen
2007-11-21  0:32     ` Roland McGrath
2007-11-19 22:06 ` [PATCH 16/18] x86 vDSO: ia32 vsyscall removal Roland McGrath
2007-11-19 22:07 ` [PATCH 17/18] x86 vDSO: reorder vdso32 code Roland McGrath
2007-11-19 22:07 ` [PATCH 18/18] x86 vDSO: makefile cleanup Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119220206.4CE4D26F8BE@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®