mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Roland McGrath <roland@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	Thomas Gleixner <tglx@linutronix.de>,
	Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH 13/18] x86 vDSO: ia32 sysenter_return
Date: Mon, 19 Nov 2007 14:06:22 -0800 (PST)	[thread overview]
Message-ID: <20071119220622.C5ED026F8BE@magilla.localdomain> (raw)
In-Reply-To: Roland McGrath's message of  Monday, 19 November 2007 13:59:43 -0800 <20071119215944.01B7C26F8BE@magilla.localdomain>


This changes the 64-bit kernel's support for the 32-bit sysenter
instruction to use stored fields rather than constants for the
user-mode return address, as the 32-bit kernel does.  This adds a
sysenter_return field to struct thread_info, as 32-bit has.  There
is no observable effect from this yet.  It makes the assembly code
independent of the 32-bit vDSO mapping address, paving the way for
making the vDSO address vary as it does on the 32-bit kernel.

Signed-off-by: Roland McGrath <roland@redhat.com>
---
 arch/x86/ia32/ia32entry.S        |    7 +++----
 arch/x86/ia32/syscall32.c        |    4 ++++
 arch/x86/kernel/asm-offsets_64.c |    1 +
 include/asm-x86/thread_info_64.h |    3 +++
 4 files changed, 11 insertions(+), 4 deletions(-)

diff --git a/arch/x86/ia32/ia32entry.S b/arch/x86/ia32/ia32entry.S
index df588f0..2499a32 100644
--- a/arch/x86/ia32/ia32entry.S
+++ b/arch/x86/ia32/ia32entry.S
@@ -12,7 +12,6 @@
 #include <asm/ia32_unistd.h>	
 #include <asm/thread_info.h>	
 #include <asm/segment.h>
-#include <asm/vsyscall32.h>
 #include <asm/irqflags.h>
 #include <linux/linkage.h>
 
@@ -104,7 +103,7 @@ ENTRY(ia32_sysenter_target)
 	pushfq
 	CFI_ADJUST_CFA_OFFSET 8
 	/*CFI_REL_OFFSET rflags,0*/
-	movl	$VSYSCALL32_SYSEXIT, %r10d
+	movl	8*3-THREAD_SIZE+threadinfo_sysenter_return(%rsp), %r10d
 	CFI_REGISTER rip,r10
 	pushq	$__USER32_CS
 	CFI_ADJUST_CFA_OFFSET 8
@@ -142,6 +141,8 @@ sysenter_do_call:
 	andl    $~TS_COMPAT,threadinfo_status(%r10)
 	/* clear IF, that popfq doesn't enable interrupts early */
 	andl  $~0x200,EFLAGS-R11(%rsp) 
+	movl	RIP-R11(%rsp),%edx		/* User %eip */
+	CFI_REGISTER rip,rdx
 	RESTORE_ARGS 1,24,1,1,1,1
 	popfq
 	CFI_ADJUST_CFA_OFFSET -8
@@ -149,8 +150,6 @@ sysenter_do_call:
 	popq	%rcx				/* User %esp */
 	CFI_ADJUST_CFA_OFFSET -8
 	CFI_REGISTER rsp,rcx
-	movl	$VSYSCALL32_SYSEXIT,%edx	/* User %eip */
-	CFI_REGISTER rip,rdx
 	TRACE_IRQS_ON
 	swapgs
 	sti		/* sti only takes effect after the next instruction */
diff --git a/arch/x86/ia32/syscall32.c b/arch/x86/ia32/syscall32.c
index 15013ba..2c9c145 100644
--- a/arch/x86/ia32/syscall32.c
+++ b/arch/x86/ia32/syscall32.c
@@ -45,6 +45,10 @@ int syscall32_setup_pages(struct linux_binprm *bprm, int exstack)
 				      VM_MAYREAD|VM_MAYWRITE|VM_MAYEXEC|
 				      VM_ALWAYSDUMP,
 				      syscall32_pages);
+	if (ret == 0) {
+		current->mm->context.vdso = (void __user *)VSYSCALL32_BASE;
+		current_thread_info()->sysenter_return = VSYSCALL32_SYSEXIT;
+	}
 	up_write(&mm->mmap_sem);
 	return ret;
 }
diff --git a/arch/x86/kernel/asm-offsets_64.c b/arch/x86/kernel/asm-offsets_64.c
index d1b6ed9..1f9b0b5 100644
--- a/arch/x86/kernel/asm-offsets_64.c
+++ b/arch/x86/kernel/asm-offsets_64.c
@@ -47,6 +47,7 @@ int main(void)
 	ENTRY(addr_limit);
 	ENTRY(preempt_count);
 	ENTRY(status);
+	ENTRY(sysenter_return);
 	BLANK();
 #undef ENTRY
 #define ENTRY(entry) DEFINE(pda_ ## entry, offsetof(struct x8664_pda, entry))
diff --git a/include/asm-x86/thread_info_64.h b/include/asm-x86/thread_info_64.h
index beae2bf..f81638e 100644
--- a/include/asm-x86/thread_info_64.h
+++ b/include/asm-x86/thread_info_64.h
@@ -33,6 +33,9 @@ struct thread_info {
 
 	mm_segment_t		addr_limit;	
 	struct restart_block    restart_block;
+#ifdef CONFIG_IA32_EMULATION
+	void __user		*sysenter_return;
+#endif
 };
 #endif
 

  parent reply	other threads:[~2007-11-19 22:09 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-19 21:59 [PATCH 00/18] x86 vDSO revamp Roland McGrath
2007-11-19 22:01 ` [PATCH 01/18] x86 vDSO: generate vdso-syms.lds Roland McGrath
2007-11-19 22:02 ` [PATCH 02/18] x86 vDSO: use vdso-syms.lds Roland McGrath
2007-11-19 22:02 ` [PATCH 03/18] x86 vDSO: remove vdso-syms.o Roland McGrath
2007-11-19 22:03 ` [PATCH 04/18] x86 vDSO: new layout Roland McGrath
2007-11-19 22:03 ` [PATCH 05/18] x86 vDSO: harmonize asm-offsets Roland McGrath
2007-11-19 22:04 ` [PATCH 06/18] x86 vDSO: arch/x86/vdso/vdso32 Roland McGrath
2007-11-20 13:05   ` Thomas Gleixner
2007-11-20 20:57     ` Roland McGrath
2007-11-20 23:07       ` Thomas Gleixner
2007-11-20 23:27         ` Roland McGrath
2007-11-20 23:50           ` Thomas Gleixner
2007-11-27  1:53           ` Linus Torvalds
2007-11-27  2:01             ` Roland McGrath
2007-11-19 22:05 ` [PATCH 07/18] x86 vDSO: vdso32 build Roland McGrath
2007-11-21  6:02   ` Sam Ravnborg
2007-11-21  7:10     ` Roland McGrath
2007-11-21  7:32       ` Sam Ravnborg
2007-11-21  7:55         ` Roland McGrath
2007-11-19 22:05 ` [PATCH 08/18] x86 vDSO: i386 vdso32 Roland McGrath
2007-11-19 22:05 ` [PATCH 09/18] x86 vDSO: absolute relocs Roland McGrath
2007-11-19 22:05 ` [PATCH 10/18] x86 vDSO: i386 vdso32 install Roland McGrath
2007-11-19 22:06 ` [PATCH 11/18] x86 vDSO: vdso32 setup Roland McGrath
2007-11-19 22:06 ` [PATCH 12/18] x86 vDSO: ia32_sysenter_target Roland McGrath
2007-11-19 22:06 ` Roland McGrath [this message]
2007-11-21  0:05   ` [PATCH 13/18] x86 vDSO: ia32 sysenter_return Zachary Amsden
2007-11-21  0:34     ` Roland McGrath
2007-11-19 22:06 ` [PATCH 14/18] x86 vDSO: ia32 vdso32-syscall build Roland McGrath
2007-11-19 22:06 ` [PATCH 15/18] x86 vDSO: consolidate vdso32 Roland McGrath
2007-11-21  0:13   ` Zachary Amsden
2007-11-21  0:13     ` Ingo Molnar
2007-11-21  0:15     ` Andi Kleen
2007-11-21  0:32     ` Roland McGrath
2007-11-19 22:06 ` [PATCH 16/18] x86 vDSO: ia32 vsyscall removal Roland McGrath
2007-11-19 22:07 ` [PATCH 17/18] x86 vDSO: reorder vdso32 code Roland McGrath
2007-11-19 22:07 ` [PATCH 18/18] x86 vDSO: makefile cleanup Roland McGrath

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071119220622.C5ED026F8BE@magilla.localdomain \
    --to=roland@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®