* [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list.
@ 2007-11-19 12:52 Heiko Carstens
2007-11-19 13:50 ` Alan Cox
2007-11-20 7:02 ` Andrew Morton
0 siblings, 2 replies; 4+ messages in thread
From: Heiko Carstens @ 2007-11-19 12:52 UTC (permalink / raw)
To: Andrew Morton, linux-kernel; +Cc: Alan Cox
From: Heiko Carstens <heiko.carstens@de.ibm.com>
Make them depend on TCGETS2. If that one is implemented the rest
should be there as well.
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
---
fs/compat_ioctl.c | 6 ++++++
1 file changed, 6 insertions(+)
Index: linux-2.6/fs/compat_ioctl.c
===================================================================
--- linux-2.6.orig/fs/compat_ioctl.c
+++ linux-2.6/fs/compat_ioctl.c
@@ -1954,6 +1954,12 @@ ULONG_IOCTL(TIOCSCTTY)
COMPATIBLE_IOCTL(TIOCGPTN)
COMPATIBLE_IOCTL(TIOCSPTLCK)
COMPATIBLE_IOCTL(TIOCSERGETLSR)
+#ifdef TCGETS2
+COMPATIBLE_IOCTL(TCGETS2)
+COMPATIBLE_IOCTL(TCSETS2)
+COMPATIBLE_IOCTL(TCSETSW2)
+COMPATIBLE_IOCTL(TCSETSF2)
+#endif
/* Little f */
COMPATIBLE_IOCTL(FIOCLEX)
COMPATIBLE_IOCTL(FIONCLEX)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list.
2007-11-19 12:52 [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list Heiko Carstens
@ 2007-11-19 13:50 ` Alan Cox
2007-11-20 7:02 ` Andrew Morton
1 sibling, 0 replies; 4+ messages in thread
From: Alan Cox @ 2007-11-19 13:50 UTC (permalink / raw)
To: Heiko Carstens; +Cc: Andrew Morton, linux-kernel
On Mon, 19 Nov 2007 13:52:06 +0100
Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Make them depend on TCGETS2. If that one is implemented the rest
> should be there as well.
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
Acked-by: Alan Cox <alan@redhat.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list.
2007-11-19 12:52 [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list Heiko Carstens
2007-11-19 13:50 ` Alan Cox
@ 2007-11-20 7:02 ` Andrew Morton
2007-11-20 8:30 ` Heiko Carstens
1 sibling, 1 reply; 4+ messages in thread
From: Andrew Morton @ 2007-11-20 7:02 UTC (permalink / raw)
To: Heiko Carstens; +Cc: linux-kernel, Alan Cox
On Mon, 19 Nov 2007 13:52:06 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> From: Heiko Carstens <heiko.carstens@de.ibm.com>
>
> Make them depend on TCGETS2. If that one is implemented the rest
> should be there as well.
>
> Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
> Signed-off-by: Heiko Carstens <heiko.carstens@de.ibm.com>
> ---
>
> fs/compat_ioctl.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> Index: linux-2.6/fs/compat_ioctl.c
> ===================================================================
> --- linux-2.6.orig/fs/compat_ioctl.c
> +++ linux-2.6/fs/compat_ioctl.c
> @@ -1954,6 +1954,12 @@ ULONG_IOCTL(TIOCSCTTY)
> COMPATIBLE_IOCTL(TIOCGPTN)
> COMPATIBLE_IOCTL(TIOCSPTLCK)
> COMPATIBLE_IOCTL(TIOCSERGETLSR)
> +#ifdef TCGETS2
> +COMPATIBLE_IOCTL(TCGETS2)
> +COMPATIBLE_IOCTL(TCSETS2)
> +COMPATIBLE_IOCTL(TCSETSW2)
> +COMPATIBLE_IOCTL(TCSETSF2)
> +#endif
> /* Little f */
> COMPATIBLE_IOCTL(FIOCLEX)
> COMPATIBLE_IOCTL(FIONCLEX)
Should this be in 2.6.24?
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list.
2007-11-20 7:02 ` Andrew Morton
@ 2007-11-20 8:30 ` Heiko Carstens
0 siblings, 0 replies; 4+ messages in thread
From: Heiko Carstens @ 2007-11-20 8:30 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-kernel, Alan Cox
On Mon, Nov 19, 2007 at 11:02:49PM -0800, Andrew Morton wrote:
> On Mon, 19 Nov 2007 13:52:06 +0100 Heiko Carstens <heiko.carstens@de.ibm.com> wrote:
> > Index: linux-2.6/fs/compat_ioctl.c
> > ===================================================================
> > --- linux-2.6.orig/fs/compat_ioctl.c
> > +++ linux-2.6/fs/compat_ioctl.c
> > @@ -1954,6 +1954,12 @@ ULONG_IOCTL(TIOCSCTTY)
> > COMPATIBLE_IOCTL(TIOCGPTN)
> > COMPATIBLE_IOCTL(TIOCSPTLCK)
> > COMPATIBLE_IOCTL(TIOCSERGETLSR)
> > +#ifdef TCGETS2
> > +COMPATIBLE_IOCTL(TCGETS2)
> > +COMPATIBLE_IOCTL(TCSETS2)
> > +COMPATIBLE_IOCTL(TCSETSW2)
> > +COMPATIBLE_IOCTL(TCSETSF2)
> > +#endif
> > /* Little f */
> > COMPATIBLE_IOCTL(FIOCLEX)
> > COMPATIBLE_IOCTL(FIONCLEX)
>
> Should this be in 2.6.24?
Can't hurt. At least it passed Alan's test suite on s390 (32 bit, 64 bit
and compat mode).
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2007-11-20 8:31 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-19 12:52 [PATCH 1/3] tty: Add the new termios2 ioctls to the compatible list Heiko Carstens
2007-11-19 13:50 ` Alan Cox
2007-11-20 7:02 ` Andrew Morton
2007-11-20 8:30 ` Heiko Carstens
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®