mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Rene Herman <rene.herman@keyaccess.nl>,
	"Li, Shaohua" <shaohua.li@intel.com>,
	"yakui.zhao" <yakui.zhao@intel.com>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table
Date: Tue, 20 Nov 2007 12:31:02 +0000	[thread overview]
Message-ID: <20071120123102.03bdaa67@the-village.bc.nu> (raw)
In-Reply-To: <1195552283.23700.166.camel@queen.suse.de>

On Tue, 20 Nov 2007 10:51:23 +0100
Thomas Renninger <trenn@suse.de> wrote:

> Unify the pnp macros to access resources in the pnp resource table

NAK

> port, mem, dma and irq resource macros are now all used in the same
> way. This is the basis (or makes it at least easier) for changing how
> the resources are allocated for memory optimizations.
> 
> Signed-off-by: Thomas Renninger <trenn@suse.de>

I really don't like this change.

_start implies an _end and an _len. IRQs have none of those features, nor
are they ranges.

Alan

  parent reply	other threads:[~2007-11-20 12:33 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-20  9:51 Thomas Renninger
2007-11-20 10:17 ` Rene Herman
2007-11-20 12:31 ` Alan Cox [this message]
2007-11-20 14:19   ` Thomas Renninger
2007-11-20 14:31     ` Rene Herman
2007-11-20 16:48       ` Thomas Renninger
2007-11-21  9:53       ` [alsa-devel] " Takashi Iwai
2007-11-27 16:34         ` Thomas Renninger
2007-11-27 16:52           ` Rene Herman
2007-11-20 15:14     ` Alan Cox
2007-11-20 18:59       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071120123102.03bdaa67@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    --cc=shaohua.li@intel.com \
    --cc=trenn@suse.de \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®