mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: trenn@suse.de
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
	Bjorn Helgaas <bjorn.helgaas@hp.com>,
	Rene Herman <rene.herman@keyaccess.nl>,
	"Li, Shaohua" <shaohua.li@intel.com>,
	"yakui.zhao" <yakui.zhao@intel.com>,
	akpm <akpm@linux-foundation.org>
Subject: Re: [PATCH 2/3] PNP cleanups - Unify the pnp macros to access resources in the pnp resource table
Date: Tue, 20 Nov 2007 15:14:04 +0000	[thread overview]
Message-ID: <20071120151404.4332d0d4@the-village.bc.nu> (raw)
In-Reply-To: <1195568360.23700.202.camel@queen.suse.de>

> At the end is some example code how things could get even more cleaned
> up. It shows how I think pnp layer and one example driver would get

Your example adds rather than removes code.

> If this is not an option, please advise how to move on here:
> Still use struct resources for dma and irq, but just do not name it
> _start, but name the macro pnp_irq_no?

Is it actually even worth changing in the first place ? You seem to be
complicating the code not simplyifying it, and at the end of the day
ISAPnP is obsolete and BIOS PnP is obsoleted by ACPI

Alan

  parent reply	other threads:[~2007-11-20 15:16 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-20  9:51 Thomas Renninger
2007-11-20 10:17 ` Rene Herman
2007-11-20 12:31 ` Alan Cox
2007-11-20 14:19   ` Thomas Renninger
2007-11-20 14:31     ` Rene Herman
2007-11-20 16:48       ` Thomas Renninger
2007-11-21  9:53       ` [alsa-devel] " Takashi Iwai
2007-11-27 16:34         ` Thomas Renninger
2007-11-27 16:52           ` Rene Herman
2007-11-20 15:14     ` Alan Cox [this message]
2007-11-20 18:59       ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071120151404.4332d0d4@the-village.bc.nu \
    --to=alan@lxorguk.ukuu.org.uk \
    --cc=akpm@linux-foundation.org \
    --cc=bjorn.helgaas@hp.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rene.herman@keyaccess.nl \
    --cc=shaohua.li@intel.com \
    --cc=trenn@suse.de \
    --cc=yakui.zhao@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®