From: Oleg Nesterov <oleg@tv-sign.ru>
To: Roland McGrath <roland@redhat.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] kill PT_PTRACED
Date: Wed, 21 Nov 2007 00:20:32 +0300 [thread overview]
Message-ID: <20071120212031.GA157@tv-sign.ru> (raw)
In-Reply-To: <20071120210840.94CB726F8BE@magilla.localdomain>
On 11/20, Roland McGrath wrote:
>
> Subject should be "kill PT_ATTACHED".
>
> > - (!(child->ptrace & PT_ATTACHED) || child->real_parent != current)
> > - && child->signal != NULL) {
> > + child->sighand != NULL) {
>
> This does s/signal/sighand/ without comment.
Ah yes, sorry, forgot to add the comment.
This is microoptimization, both ->signal and ->sighand are cleared at the same
time in __exit_signal(), so we can check either. But we are using the value of
->sighand below, so it makes sense to read ->sighand, not ->signal.
Andrew, it is very easy to send the new patch to fix the code, but is it possible
to fix the changelog somehow for the patch in -mm tree?
Oleg.
next prev parent reply other threads:[~2007-11-20 21:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 15:21 Oleg Nesterov
2007-11-20 21:08 ` Roland McGrath
2007-11-20 21:20 ` Oleg Nesterov [this message]
2007-11-20 21:28 ` Roland McGrath
2007-11-20 21:37 ` Andrew Morton
2007-11-20 21:43 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120212031.GA157@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®