From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>,
torvalds@linux-foundation.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH -mm 1/2] kill PT_PTRACED
Date: Wed, 21 Nov 2007 00:43:44 +0300 [thread overview]
Message-ID: <20071120214344.GA177@tv-sign.ru> (raw)
In-Reply-To: <20071120133743.117c4e61.akpm@linux-foundation.org>
On 11/20, Andrew Morton wrote:
>
> On Tue, 20 Nov 2007 13:28:51 -0800 (PST)
> Roland McGrath <roland@redhat.com> wrote:
>
> > > Andrew, it is very easy to send the new patch to fix the code, but is it
> > > possible to fix the changelog somehow for the patch in -mm tree?
>
> Sure, just send me the new text.
>
> > I'd prefer a comment in the code there making it explicit that ->sighand is
> > a "reaped yet" synchronization check (under tasklist_lock).
>
> that works too.
Will do tomorrow. Actually, I just realized we don't need need either check.
release_task() first does ptrace_unlink(), then __exit_signal(). This means
that (child->ptrace & PT_PTRACED) under tasklist_lock implies we have the valid
->sighand/signal.
Will send the patch with the comment.
Oleg.
prev parent reply other threads:[~2007-11-20 21:44 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-20 15:21 Oleg Nesterov
2007-11-20 21:08 ` Roland McGrath
2007-11-20 21:20 ` Oleg Nesterov
2007-11-20 21:28 ` Roland McGrath
2007-11-20 21:37 ` Andrew Morton
2007-11-20 21:43 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120214344.GA177@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®