From: Alasdair G Kergon <agk@redhat.com>
To: Milan Broz <mbroz@redhat.com>
Cc: Ingo Molnar <mingo@elte.hu>,
Torsten Kaiser <just.for.lkml@googlemail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.24-rc2-mm1: kcryptd vs lockdep
Date: Tue, 20 Nov 2007 23:36:12 +0000 [thread overview]
Message-ID: <20071120233612.GA9126@agk.fab.redhat.com> (raw)
In-Reply-To: <4742F1DE.1090902@redhat.com>
On Tue, Nov 20, 2007 at 03:40:30PM +0100, Milan Broz wrote:
> (Note comment in code "It is permissible to free the struct
> work_struct from inside the function that is called from it".)
I don't understand yet how lockdep behaves if the work struct gets
reused and the reused one finishes first.
I renamed the kcryptd functions today in an attempt to disentangle this
code a bit more.
- io->pending reference counting looks correct (though used
inconsistently when comparing READ with WRITE)
- But what happens if kcryptd_crypt_write_convert_loop() calls
INIT_WORK/queue_work twice?
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2007-11-20 23:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 7:23 Torsten Kaiser
2007-11-19 7:56 ` Ingo Molnar
2007-11-19 19:34 ` Torsten Kaiser
2007-11-19 21:00 ` Milan Broz
2007-11-20 6:55 ` Torsten Kaiser
2007-11-20 14:40 ` Milan Broz
2007-11-20 23:36 ` Alasdair G Kergon [this message]
2007-11-23 10:21 ` Torsten Kaiser
2007-11-23 22:42 ` Torsten Kaiser
2007-11-24 3:49 ` Alasdair G Kergon
2007-11-24 4:03 ` Alasdair G Kergon
2007-11-24 6:38 ` Herbert Xu
2007-11-24 4:57 ` Torsten Kaiser
2007-11-24 4:13 ` Alasdair G Kergon
[not found] <20071120234605.GG23667@elte.hu>
2007-11-21 15:58 ` Oleg Nesterov
2007-11-21 16:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071120233612.GA9126@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®