From: Alasdair G Kergon <agk@redhat.com>
To: Torsten Kaiser <just.for.lkml@googlemail.com>
Cc: Milan Broz <mbroz@redhat.com>, Ingo Molnar <mingo@elte.hu>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.24-rc2-mm1: kcryptd vs lockdep
Date: Sat, 24 Nov 2007 04:13:24 +0000 [thread overview]
Message-ID: <20071124041324.GE22843@agk.fab.redhat.com> (raw)
In-Reply-To: <64bb37e0711231442y7603366aib9642eab97e5be6b@mail.gmail.com>
On Fri, Nov 23, 2007 at 11:42:36PM +0100, Torsten Kaiser wrote:
> Before the cleanup *all* calls to crypt_dec_pending() was via crypt_endio().
> Now there is an additional call to crypt_dec_pending() to balance the
> additional ref placed into crypt_write_io_process(). And that one is
> not called from whatever context/thread cleans up after
> make_generic_request, but directly in the context/thread of the caller
> of crypt_write_io_process(), and that is kcryptd.
Please do look at the latest patches (always at
http://www.kernel.org/pub/linux/kernel/people/agk/patches/2.6/editing/series.html )
where you'll see I've already disentangled the mess of functions
and given them more understandable names, so at least following the program
flow is easier.
Read and write do the ref counting differently (but correctly AFAICT) - I want
that changing, but held back from doing it without first checking whether the
later patches (not yet reviewed) provide a reason to prefer one method
over the other.
Alasdair
--
agk@redhat.com
next prev parent reply other threads:[~2007-11-24 4:13 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-19 7:23 Torsten Kaiser
2007-11-19 7:56 ` Ingo Molnar
2007-11-19 19:34 ` Torsten Kaiser
2007-11-19 21:00 ` Milan Broz
2007-11-20 6:55 ` Torsten Kaiser
2007-11-20 14:40 ` Milan Broz
2007-11-20 23:36 ` Alasdair G Kergon
2007-11-23 10:21 ` Torsten Kaiser
2007-11-23 22:42 ` Torsten Kaiser
2007-11-24 3:49 ` Alasdair G Kergon
2007-11-24 4:03 ` Alasdair G Kergon
2007-11-24 6:38 ` Herbert Xu
2007-11-24 4:57 ` Torsten Kaiser
2007-11-24 4:13 ` Alasdair G Kergon [this message]
[not found] <20071120234605.GG23667@elte.hu>
2007-11-21 15:58 ` Oleg Nesterov
2007-11-21 16:06 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071124041324.GE22843@agk.fab.redhat.com \
--to=agk@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=just.for.lkml@googlemail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®