mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Madhusudhan C <madhu_lkml@yahoo.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: mmc select voltage functionality
Date: Mon, 26 Nov 2007 18:46:17 +0100	[thread overview]
Message-ID: <20071126184617.04029484@poseidon.drzeus.cx> (raw)
In-Reply-To: <655340.80743.qm@web44811.mail.sp1.yahoo.com>

On Thu, 22 Nov 2007 05:34:11 -0800 (PST)
Madhusudhan C <madhu_lkml@yahoo.com> wrote:

> Hi Pierre,
> 
> I have a question on the mmc_select_voltage fn of the mmc core file drivers/mmc/core/core.c.
> 
> During the power up sequence the mmc_power_up fn sets the OCR bit to setup 3V. Subsequentely the mmc_select_voltage fn selects the lowest voltage
> the card can support.The host->ios.power_mode is not changed to MMC_POWER_UP before calling mmc_set_ios from this function hence the power_mode remains in MMC_POWER_ON state.So my question is, how should the controller driver handle this change in volatge. Under which case of power mode should the controller driver change the voltage again when a dual voltage card is detected?
> 

To be completely correct, the MMC layer should probably power down the card first, yes. Right now most drivers will handle all of these things as they see fit. Haven't seen a single bug report about it yet so...

Just change the voltage in whatever way makes sense for your controller.

Rgds
-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  PulseAudio, core developer          http://pulseaudio.org
  rdesktop, core developer          http://www.rdesktop.org

           reply	other threads:[~2007-11-26 17:46 UTC|newest]

Thread overview: expand[flat|nested]  mbox.gz  Atom feed
 [parent not found: <655340.80743.qm@web44811.mail.sp1.yahoo.com>]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071126184617.04029484@poseidon.drzeus.cx \
    --to=drzeus-mmc@drzeus.cx \
    --cc=linux-kernel@vger.kernel.org \
    --cc=madhu_lkml@yahoo.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®