From: Oleg Nesterov <oleg@tv-sign.ru>
To: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
Date: Tue, 27 Nov 2007 01:46:49 +0300 [thread overview]
Message-ID: <20071126224649.GA393@tv-sign.ru> (raw)
In-Reply-To: <m1r6icn0s9.fsf@ebiederm.dsl.xmission.com>
On 11/26, Eric W. Biederman wrote:
>
> Oleg Nesterov <oleg@tv-sign.ru> writes:
>
> > This is different, perhaps we can keep this call. kernel_thread(kernel_init)
> > attaches /sbin/init to init_struct_pid. Nothing bad, and a "good" init should
> > do setsid() anyway. But who knows? Some special environment may expect that
> > getpgrp() != 0. Not that I really disagree on this issue though.
>
> init starting with session == pgrp == 0 is historical linux behavior. I consider
> the current 2.6 behavior a temporary aberation from the historical linux behavior.
Ah, OK.
> Plus once we do this the code will be easier to maintain because we have
> removed one obscure special case.
Yes indeed. So we can remove this special case code as soon as copy_process()
is changed.
Oleg.
prev parent reply other threads:[~2007-11-26 22:48 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 14:25 Oleg Nesterov
2007-11-26 14:43 ` Oleg Nesterov
2007-11-26 15:00 ` Pavel Emelyanov
2007-11-26 19:16 ` Eric W. Biederman
2007-11-26 20:11 ` Oleg Nesterov
2007-11-26 21:40 ` Eric W. Biederman
2007-11-26 22:46 ` Oleg Nesterov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071126224649.GA393@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=ebiederm@xmission.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®