From: ebiederm@xmission.com (Eric W. Biederman)
To: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Pavel Emelyanov <xemul@openvz.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] fix setsid() for sub-namespace /sbin/init
Date: Mon, 26 Nov 2007 12:16:21 -0700 [thread overview]
Message-ID: <m1zlx0n7ga.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20071126142553.GA16525@tv-sign.ru> (Oleg Nesterov's message of "Mon, 26 Nov 2007 17:25:53 +0300")
Oleg Nesterov <oleg@tv-sign.ru> writes:
> sys_setsid() still deals with pid_t's from the global namespace. This means
> that the "session > 1" check can't help for sub-namespace init, setsid() can't
> succeed because copy_process(CLONE_NEWPID) populates PIDTYPE_PGID/SID links.
We can do even better. We can remove the misguided code from
copy_process(CLONE_NEWPID) that populates the PIDTYPE_PGID/SID links
and generally does set setsid by hand, and the code from kernel_init
that call set_special_pid(), allowing us to remove the special case
entirely.
The set_special_pid() in kernel_init() and the special case check
is actually a work around for the fact that earlier we could not
use 0 in the pid hash table. Now that we can use init_struct_pid
directly we don't need the special case at all.
Eric
next prev parent reply other threads:[~2007-11-26 19:17 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-26 14:25 Oleg Nesterov
2007-11-26 14:43 ` Oleg Nesterov
2007-11-26 15:00 ` Pavel Emelyanov
2007-11-26 19:16 ` Eric W. Biederman [this message]
2007-11-26 20:11 ` Oleg Nesterov
2007-11-26 21:40 ` Eric W. Biederman
2007-11-26 22:46 ` Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=m1zlx0n7ga.fsf@ebiederm.dsl.xmission.com \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=oleg@tv-sign.ru \
--cc=xemul@openvz.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®