* [PATCH -mm] printk trivial optimizations fix
@ 2007-11-28 19:02 Hugh Dickins
2007-11-29 4:06 ` Denys Vlasenko
0 siblings, 1 reply; 2+ messages in thread
From: Hugh Dickins @ 2007-11-28 19:02 UTC (permalink / raw)
To: Andrew Morton; +Cc: Denys Vlasenko, linux-kernel
mm's printk has been showing "%p" in abominable upper case recently:
its trivial optimizations have changed the default from lower to upper,
so the 'p' case needs to enforce lower explicitly.
Signed-off-by: Hugh Dickins <hugh@veritas.com>
---
lib/vsprintf.c | 1 +
1 file changed, 1 insertion(+)
--- 2.6.24-rc3-mm2/lib/vsprintf.c 2007-11-28 12:42:26.000000000 +0000
+++ linux/lib/vsprintf.c 2007-11-28 17:01:20.000000000 +0000
@@ -525,6 +525,7 @@ int vsnprintf(char *buf, size_t size, co
continue;
case 'p':
+ flags |= SMALL;
if (field_width == -1) {
field_width = 2*sizeof(void *);
flags |= ZEROPAD;
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -mm] printk trivial optimizations fix
2007-11-28 19:02 [PATCH -mm] printk trivial optimizations fix Hugh Dickins
@ 2007-11-29 4:06 ` Denys Vlasenko
0 siblings, 0 replies; 2+ messages in thread
From: Denys Vlasenko @ 2007-11-29 4:06 UTC (permalink / raw)
To: Hugh Dickins; +Cc: Andrew Morton, linux-kernel
On Wednesday 28 November 2007 11:02, Hugh Dickins wrote:
> mm's printk has been showing "%p" in abominable upper case recently:
> its trivial optimizations have changed the default from lower to upper,
> so the 'p' case needs to enforce lower explicitly.
>
> Signed-off-by: Hugh Dickins <hugh@veritas.com>
> ---
>
> lib/vsprintf.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- 2.6.24-rc3-mm2/lib/vsprintf.c 2007-11-28 12:42:26.000000000 +0000
> +++ linux/lib/vsprintf.c 2007-11-28 17:01:20.000000000 +0000
> @@ -525,6 +525,7 @@ int vsnprintf(char *buf, size_t size, co
> continue;
>
> case 'p':
> + flags |= SMALL;
> if (field_width == -1) {
> field_width = 2*sizeof(void *);
> flags |= ZEROPAD;
Thanks Hugh for catching this. My fault :(
--
vda
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-11-29 4:06 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-11-28 19:02 [PATCH -mm] printk trivial optimizations fix Hugh Dickins
2007-11-29 4:06 ` Denys Vlasenko
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome