From: Alessandro Zummo <alessandro.zummo@towertech.it>
To: rtc-linux@googlegroups.com
Cc: vapier.adi@gmail.com, "Bryan Wu" <bryan.wu@analog.com>,
linux-kernel@vger.kernel.org,
uclinux-dist-devel@blackfin.uclinux.org,
"Mike Frysinger" <michael.frysinger@analog.com>
Subject: Re: [rtc-linux] Re: [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz
Date: Tue, 4 Dec 2007 17:41:46 +0100 [thread overview]
Message-ID: <20071204174146.19bedb54@i1501.lan.towertech.it> (raw)
In-Reply-To: <8bd0f97a0712040829i116496deu384453c6eccfa252@mail.gmail.com>
On Tue, 4 Dec 2007 11:29:11 -0500
"Mike Frysinger" <vapier.adi@gmail.com> wrote:
>
> On Dec 4, 2007 11:26 AM, Alessandro Zummo <alessandro.zummo@towertech.it> wrote:
> > Bryan Wu <bryan.wu@analog.com> wrote:
> >
> > Hi, I fannly got some time to review the patches. Seems ok, the
> > only question is...
> >
> > > static int bfin_irq_set_freq(struct device *dev, int freq)
> > > {
> > > - struct bfin_rtc *rtc = dev_get_drvdata(dev);
> > > stampit();
> > > - rtc->rtc_dev->irq_freq = freq;
> > > - return 0;
> > > + return -ENOTTY;
> > > }
> >
> > .. why ENOTTY here?
>
> blah, hit "reply" in previous e-mail ...
>
> that's what the documentation says to do as does every other rtc driver ?
> -mike
it should be EINVAL. at least it is wat rtc-cmos does when the value
is invalid.
--
Best regards,
Alessandro Zummo,
Tower Technologies - Torino, Italy
http://www.towertech.it
next prev parent reply other threads:[~2007-12-04 16:42 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-23 10:08 [PATCH 0/7] Blackfin On-Chip RTC driver updates Bryan Wu
2007-11-23 10:08 ` [PATCH 1/7] Blackfin RTC driver: the frequency function is in units of Hz, not units of seconds, so lock our driver down to 1 Hz Bryan Wu
2007-12-04 16:26 ` Alessandro Zummo
2007-12-04 16:29 ` [rtc-linux] " Mike Frysinger
2007-12-04 16:41 ` Alessandro Zummo [this message]
2007-12-04 16:47 ` Mike Frysinger
2007-12-04 16:49 ` Alessandro Zummo
2007-12-04 16:56 ` Mike Frysinger
2007-12-04 16:59 ` Alessandro Zummo
2007-12-04 17:15 ` Mike Frysinger
2007-11-23 10:08 ` [PATCH 2/7] Blackfin RTC driver: we pass in a (struct device*) to the irq handler, not a (struct platform_device*), so fix the irq handler Bryan Wu
2007-11-23 10:08 ` [PATCH 3/7] Blackfin RTC driver: cleanup proc handler (we dont need RTC reg dump now that we have MMR filesystem in sysfs) Bryan Wu
2007-11-23 10:08 ` [PATCH 4/7] Blackfin RTC driver: use dev_dbg() rather than pr_stamp() Bryan Wu
2007-11-23 10:08 ` [PATCH 5/7] Blackfin RTC driver: read_alarm() checks the enabled field, not the pending field Bryan Wu
2007-11-23 10:08 ` [PATCH 6/7] Blackfin RTC driver: shave off another memcpy() by using assignment Bryan Wu
2007-11-23 10:08 ` [PATCH 7/7] Blackfin RTC driver: convert sync wait to use the irq write complete notice Bryan Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071204174146.19bedb54@i1501.lan.towertech.it \
--to=alessandro.zummo@towertech.it \
--cc=bryan.wu@analog.com \
--cc=linux-kernel@vger.kernel.org \
--cc=michael.frysinger@analog.com \
--cc=rtc-linux@googlegroups.com \
--cc=uclinux-dist-devel@blackfin.uclinux.org \
--cc=vapier.adi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome