mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: viro@ftp.linux.org.uk, hch@infradead.org,
	Trond.Myklebust@netapp.com, sds@tycho.nsa.gov,
	casey@schaufler-ca.com
Cc: linux-kernel@vger.kernel.org, selinux@tycho.nsa.gov,
	linux-security-module@vger.kernel.org, dhowells@redhat.com
Subject: [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache [try #2]
Date: Wed, 05 Dec 2007 19:40:20 +0000	[thread overview]
Message-ID: <20071205194020.24617.28880.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20071205193818.24617.79771.stgit@warthog.procyon.org.uk>

Add a function - cancel_rejected_write() - to excise a rejected write from the
pagecache.  This function is related to the truncation family of routines.  It
permits the pages modified by a network filesystem client (such as AFS) to be
excised and discarded from the pagecache if the attempt to write them back to
the server fails.

The dirty and writeback states of the afflicted pages are cancelled and the
pages themselves are detached for recycling.  All PTEs referring to those
pages are removed.

Note that the locking is tricky as it's very easy to deadlock against
truncate() and other routines once the pages have been unlocked as part of the
writeback process.  To this end, the PG_error flag is set, then the
PG_writeback flag is cleared, and only *then* can lock_page() be called.

Signed-off-by: David Howells <dhowells@redhat.com>
---

 include/linux/mm.h |    5 ++-
 mm/truncate.c      |   83 ++++++++++++++++++++++++++++++++++++++++++++++++++++
 2 files changed, 86 insertions(+), 2 deletions(-)

diff --git a/include/linux/mm.h b/include/linux/mm.h
index 520238c..438270f 100644
--- a/include/linux/mm.h
+++ b/include/linux/mm.h
@@ -1005,12 +1005,13 @@ extern int do_munmap(struct mm_struct *, unsigned long, size_t);
 
 extern unsigned long do_brk(unsigned long, unsigned long);
 
-/* filemap.c */
-extern unsigned long page_unuse(struct page *);
+/* truncate.c */
 extern void truncate_inode_pages(struct address_space *, loff_t);
 extern void truncate_inode_pages_range(struct address_space *,
 				       loff_t lstart, loff_t lend);
+extern void cancel_rejected_write(struct address_space *, pgoff_t, pgoff_t);
 
+/* filemap.c */
 /* generic vm_area_ops exported for stackable file systems */
 extern int filemap_fault(struct vm_area_struct *, struct vm_fault *);
 
diff --git a/mm/truncate.c b/mm/truncate.c
index 5b7d1c5..95fc1a8 100644
--- a/mm/truncate.c
+++ b/mm/truncate.c
@@ -465,3 +465,86 @@ int invalidate_inode_pages2(struct address_space *mapping)
 	return invalidate_inode_pages2_range(mapping, 0, -1);
 }
 EXPORT_SYMBOL_GPL(invalidate_inode_pages2);
+
+/*
+ * Cancel that part of a rejected write that affects a particular page
+ */
+static void cancel_rejected_page(struct address_space *mapping,
+				 struct page *page, pgoff_t *_next)
+{
+	if (!TestSetPageError(page)) {
+		/* can't lock the page until we've cleared PG_writeback lest we
+		 * deadlock with truncate (amongst other things) */
+		end_page_writeback(page);
+		if (page->mapping == mapping) {
+			lock_page(page);
+			if (page->mapping == mapping) {
+				truncate_complete_page(mapping, page);
+				*_next = page->index + 1;
+			}
+			unlock_page(page);
+		}
+	} else if (PageWriteback(page) || PageDirty(page)) {
+		BUG();
+	}
+}
+
+/**
+ * cancel_rejected_write - Cancel a write on a contiguous set of pages
+ * @mapping: mapping affected
+ * @start: first page in set
+ * @end: last page in set
+ *
+ * Cancel a write of a contiguous set of pages when the writeback was rejected
+ * by the target medium or server.
+ *
+ * The pages in question are detached and discarded from the pagecache, and the
+ * writeback and dirty states are cleared prior to invalidation.  The caller
+ * must make sure that all the pages in the range are present in the pagecache,
+ * and the caller must hold PG_writeback on each of them.  NOTE! All the pages
+ * are locked and unlocked as part of this process, so the caller must take
+ * care to avoid deadlock.
+ *
+ * The PTEs pointing to those pages are also cleared, leading to the PTEs being
+ * reset when new pages are allocated and the contents reloaded.
+ */
+void cancel_rejected_write(struct address_space *mapping,
+			   pgoff_t start, pgoff_t end)
+{
+	struct pagevec pvec;
+	pgoff_t n;
+	int i;
+
+	BUG_ON(mapping->nrpages < end - start + 1);
+
+	/* dispose of any PTEs pointing to the affected pages */
+	unmap_mapping_range(mapping,
+			    (loff_t)start << PAGE_CACHE_SHIFT,
+			    (loff_t)(end - start + 1) << PAGE_CACHE_SHIFT,
+			    0);
+
+	pagevec_init(&pvec, 0);
+	do {
+		cond_resched();
+		n = end - start + 1;
+		if (n > PAGEVEC_SIZE)
+			n = PAGEVEC_SIZE;
+		n = pagevec_lookup(&pvec, mapping, start, n);
+		for (i = 0; i < n; i++) {
+			struct page *page = pvec.pages[i];
+
+			if (page->index < start || page->index > end)
+				continue;
+			start++;
+			cancel_rejected_page(mapping, page, &start);
+		}
+		pagevec_release(&pvec);
+	} while (start - 1 < end);
+
+	/* dispose of any new PTEs pointing to the affected pages */
+	unmap_mapping_range(mapping,
+			    (loff_t)start << PAGE_CACHE_SHIFT,
+			    (loff_t)(end - start + 1) << PAGE_CACHE_SHIFT,
+			    0);
+}
+EXPORT_SYMBOL_GPL(cancel_rejected_write);


  parent reply	other threads:[~2007-12-05 19:49 UTC|newest]

Thread overview: 126+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-12-05 19:38 [PATCH 00/28] Permit filesystem local caching " David Howells
2007-12-05 19:38 ` [PATCH 01/28] KEYS: Increase the payload size when instantiating a key " David Howells
2007-12-05 19:38 ` [PATCH 02/28] KEYS: Check starting keyring as part of search " David Howells
2007-12-05 19:38 ` [PATCH 03/28] KEYS: Allow the callout data to be passed as a blob rather than a string " David Howells
2007-12-05 19:38 ` [PATCH 04/28] KEYS: Add keyctl function to get a security label " David Howells
2007-12-05 19:38 ` [PATCH 05/28] Security: Change current->fs[ug]id to current_fs[ug]id() " David Howells
2007-12-05 19:38 ` [PATCH 06/28] SECURITY: Separate task security context from task_struct " David Howells
2007-12-05 19:38 ` [PATCH 07/28] SECURITY: De-embed task security record from task and use refcounting " David Howells
2007-12-05 19:38 ` [PATCH 08/28] SECURITY: Allow kernel services to override LSM settings for task actions " David Howells
2007-12-10 16:46   ` Stephen Smalley
2007-12-10 17:07   ` David Howells
2007-12-10 17:23     ` Stephen Smalley
2007-12-10 21:08     ` David Howells
2007-12-10 21:27       ` Stephen Smalley
2007-12-10 22:26         ` Casey Schaufler
2007-12-10 23:44           ` David Howells
2007-12-10 23:56             ` Casey Schaufler
2007-12-11 18:34           ` Stephen Smalley
2007-12-11 19:26             ` Casey Schaufler
2007-12-11 19:56               ` Stephen Smalley
2007-12-11 20:40                 ` Casey Schaufler
2007-12-10 23:36       ` David Howells
2007-12-10 23:46         ` Casey Schaufler
2007-12-11 19:52           ` Stephen Smalley
2007-12-11 19:37         ` Stephen Smalley
2007-12-12 14:41           ` Karl MacMillan
2007-12-12 14:53           ` David Howells
2007-12-12 14:59             ` Karl MacMillan
2007-12-11 20:42         ` David Howells
2007-12-11 21:18           ` Casey Schaufler
2007-12-11 21:34           ` Stephen Smalley
2007-12-19  3:28             ` Crispin Cowan
2007-12-19  5:39               ` Casey Schaufler
2007-12-19 14:54               ` Stephen Smalley
2007-12-11 22:43           ` David Howells
2007-12-11 23:04             ` Casey Schaufler
2007-12-12 15:25               ` Stephen Smalley
2007-12-12 16:51                 ` Casey Schaufler
2007-12-12 18:12                   ` Stephen Smalley
2007-12-12 18:34                   ` David Howells
2007-12-12 19:44                     ` Casey Schaufler
2007-12-12 19:49                       ` Stephen Smalley
2007-12-12 20:09                         ` Casey Schaufler
2007-12-12 22:29                           ` David Howells
2007-12-12 22:32                       ` David Howells
2007-12-12 18:25               ` David Howells
2007-12-12 19:20                 ` Casey Schaufler
2007-12-12 19:29                   ` David Howells
2007-12-12 19:35                   ` Stephen Smalley
2007-12-12 22:55                   ` David Howells
2007-12-13 14:51                     ` Stephen Smalley
2007-12-13 16:03                     ` David Howells
2007-12-12 18:29               ` David Howells
2007-12-12 19:33                 ` Stephen Smalley
2007-12-12 19:37                 ` Casey Schaufler
2007-12-12 22:52                   ` David Howells
2007-12-12 22:49                 ` David Howells
2007-12-13 14:49                   ` Stephen Smalley
2007-12-13 15:36                   ` David Howells
2007-12-13 16:23                     ` Stephen Smalley
2007-12-13 17:01                     ` David Howells
2007-12-13 17:27                       ` Stephen Smalley
2007-12-13 18:04                       ` David Howells
2007-12-19  3:28           ` Crispin Cowan
2007-12-19 23:38           ` David Howells
2008-01-09 16:51     ` David Howells
2008-01-09 18:11       ` Stephen Smalley
2008-01-09 18:56       ` David Howells
2008-01-09 19:19         ` Stephen Smalley
2008-01-10 11:09         ` David Howells
2008-01-14 14:01       ` David Howells
2008-01-14 14:52         ` Casey Schaufler
2008-01-14 15:19           ` David Howells
2008-01-15 14:56         ` Stephen Smalley
2008-01-15 16:03         ` David Howells
2008-01-15 16:08           ` Stephen Smalley
2008-01-15 18:10           ` Casey Schaufler
2008-01-15 19:15             ` Stephen Smalley
2008-01-15 21:55             ` David Howells
2008-01-15 22:23               ` Casey Schaufler
2008-01-14 14:06       ` David Howells
2008-01-15 14:58         ` Stephen Smalley
2008-01-23 20:52         ` David Howells
2008-01-23 22:03           ` James Morris
2008-01-09 17:27     ` David Howells
2007-12-05 19:39 ` [PATCH 09/28] FS-Cache: Release page->private after failed readahead " David Howells
2007-12-14  3:51   ` Nick Piggin
2007-12-17 22:42   ` David Howells
2007-12-18  7:03     ` Nick Piggin
2007-12-05 19:39 ` [PATCH 10/28] FS-Cache: Recruit a couple of page flags for cache management " David Howells
2007-12-14  4:08   ` Nick Piggin
2007-12-17 22:36   ` David Howells
2007-12-18  7:00     ` Nick Piggin
2007-12-20 18:33     ` David Howells
2007-12-21  1:08       ` Nick Piggin
2008-01-02 16:27       ` David Howells
2008-01-07 11:33         ` Nick Piggin
2008-01-07 13:09         ` David Howells
2008-01-08  3:01           ` Nick Piggin
2008-01-08 23:51           ` David Howells
2008-01-09  1:52             ` Nick Piggin
2008-01-09 15:45             ` David Howells
2008-01-09 23:52               ` Nick Piggin
2007-12-05 19:39 ` [PATCH 11/28] FS-Cache: Provide an add_wait_queue_tail() function " David Howells
2007-12-05 19:39 ` [PATCH 12/28] FS-Cache: Generic filesystem caching facility " David Howells
2007-12-05 19:39 ` [PATCH 13/28] CacheFiles: Add missing copy_page export for ia64 " David Howells
2007-12-05 19:39 ` [PATCH 14/28] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3 " David Howells
2007-12-05 19:39 ` [PATCH 15/28] CacheFiles: Add a hook to write a single page of data to an inode " David Howells
2007-12-05 19:39 ` [PATCH 16/28] CacheFiles: Permit the page lock state to be monitored " David Howells
2007-12-05 19:39 ` [PATCH 17/28] CacheFiles: Export things for CacheFiles " David Howells
2007-12-05 19:39 ` [PATCH 18/28] CacheFiles: A cache that backs onto a mounted filesystem " David Howells
2007-12-05 19:39 ` [PATCH 19/28] NFS: Use local caching " David Howells
2007-12-05 19:40 ` [PATCH 20/28] NFS: Configuration and mount option changes to enable local caching on NFS " David Howells
2007-12-05 19:40 ` [PATCH 21/28] NFS: Display local caching state " David Howells
2007-12-05 19:40 ` [PATCH 22/28] fcrypt endianness misannotations " David Howells
2007-12-05 19:40 ` [PATCH 23/28] AFS: Add TestSetPageError() " David Howells
2007-12-05 19:40 ` David Howells [this message]
2007-12-14  4:21   ` [PATCH 24/28] AFS: Add a function to excise a rejected write from the pagecache " Nick Piggin
2007-12-17 22:54   ` David Howells
2007-12-18  7:07     ` Nick Piggin
2007-12-20 18:49     ` David Howells
2007-12-21  1:11       ` Nick Piggin
2007-12-05 19:40 ` [PATCH 25/28] AFS: Improve handling of a rejected writeback " David Howells
2007-12-05 19:40 ` [PATCH 26/28] AF_RXRPC: Save the operation ID for debugging " David Howells
2007-12-05 19:40 ` [PATCH 27/28] AFS: Implement shared-writable mmap " David Howells
2007-12-05 19:40 ` [PATCH 28/28] FS-Cache: Make kAFS use FS-Cache " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20071205194020.24617.28880.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=Trond.Myklebust@netapp.com \
    --cc=casey@schaufler-ca.com \
    --cc=hch@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-security-module@vger.kernel.org \
    --cc=sds@tycho.nsa.gov \
    --cc=selinux@tycho.nsa.gov \
    --cc=viro@ftp.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®