From: Heiko Carstens <heiko.carstens@de.ibm.com>
To: Denis Cheng <crquan@gmail.com>
Cc: linux-s390@vger.kernel.org,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 09/20] drivers/s390/: use LIST_HEAD instead of LIST_HEAD_INIT
Date: Fri, 7 Dec 2007 09:19:24 +0100 [thread overview]
Message-ID: <20071207081924.GB8081@osiris.boeblingen.de.ibm.com> (raw)
In-Reply-To: <1196954381-5483-1-git-send-email-crquan@gmail.com>
On Thu, Dec 06, 2007 at 11:19:41PM +0800, Denis Cheng wrote:
> single list_head variable initialized with LIST_HEAD_INIT could almost
> always can be replaced with LIST_HEAD declaration, this shrinks the code
> and looks better.
>
> Signed-off-by: Denis Cheng <crquan@gmail.com>
> ---
> drivers/s390/block/dcssblk.c | 2 +-
> drivers/s390/char/raw3270.c | 4 ++--
> drivers/s390/char/tape_core.c | 2 +-
> drivers/s390/net/netiucv.c | 3 +--
> drivers/s390/net/smsgiucv.c | 2 +-
> 5 files changed, 6 insertions(+), 7 deletions(-)
Thanks, applied. I added the possible change in arch/s390/mm/extmem.c
to your patch.
prev parent reply other threads:[~2007-12-07 8:19 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-06 15:19 Denis Cheng
2007-12-07 8:19 ` Heiko Carstens [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071207081924.GB8081@osiris.boeblingen.de.ibm.com \
--to=heiko.carstens@de.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=crquan@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®