From: David Brownell <david-b@pacbell.net>
To: "Jan Beulich" <jbeulich@novell.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ohci: avoid an unused variable warning
Date: Fri, 14 Dec 2007 00:56:18 -0800 [thread overview]
Message-ID: <200712140056.18728.david-b@pacbell.net> (raw)
In-Reply-To: <47610414.76E4.0078.0@novell.com>
On Thursday 13 December 2007, Jan Beulich wrote:
>
> With CONFIG_PM, but without CONFIG_PM_SLEEP, the intention of the
> conditional in ohci_pci_start() doesn't work since device_may_wakeup()
> references pdev only with the latter config option.
Yuck. That means that runtime power management won't work correctly.
The same wakeup mechanisms that apply during SUSPEND and HIBERNATION
are also used for runtime PM(*) ... which is allowed by CONFIG_PM, and
which accordingly should not depend on PM_SLEEP.
I think the bug is that device_may_wakeup() now looks at CONFIG_PM_SLEEP
instead of just CONFIG_PM.
- Dave
(*) Although ACPI has problems with the notion of runtime PM. For
example, it ignores PCI PME# signaling until PM_SLEEP transitions.
prev parent reply other threads:[~2007-12-14 8:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 9:06 Jan Beulich
2007-12-14 8:56 ` David Brownell [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200712140056.18728.david-b@pacbell.net \
--to=david-b@pacbell.net \
--cc=jbeulich@novell.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®