From: "Jan Beulich" <jbeulich@novell.com>
To: <dbrownell@users.sourceforge.net>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH] ohci: avoid an unused variable warning
Date: Thu, 13 Dec 2007 09:06:12 +0000 [thread overview]
Message-ID: <47610414.76E4.0078.0@novell.com> (raw)
With CONFIG_PM, but without CONFIG_PM_SLEEP, the intention of the
conditional in ohci_pci_start() doesn't work since device_may_wakeup()
references pdev only with the latter config option.
Signed-off-by: Jan Beulich <jbeulich@novell.com>
drivers/usb/host/ohci-pci.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
--- linux-2.6.24-rc5/drivers/usb/host/ohci-pci.c 2007-12-12 11:29:07.000000000 +0100
+++ 2.6.24-rc5-ohci-pm-sleep/drivers/usb/host/ohci-pci.c 2007-12-04 16:09:33.000000000 +0100
@@ -217,7 +217,7 @@ static int __devinit ohci_pci_start (str
struct ohci_hcd *ohci = hcd_to_ohci (hcd);
int ret;
-#ifdef CONFIG_PM /* avoid warnings about unused pdev */
+#ifdef CONFIG_PM_SLEEP /* avoid warnings about unused pdev */
if (hcd->self.controller) {
struct pci_dev *pdev = to_pci_dev(hcd->self.controller);
next reply other threads:[~2007-12-13 9:05 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-13 9:06 Jan Beulich [this message]
2007-12-14 8:56 ` David Brownell
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=47610414.76E4.0078.0@novell.com \
--to=jbeulich@novell.com \
--cc=dbrownell@users.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®