From: Andi Kleen <ak@suse.de>
To: Parag Warudkar <parag.warudkar@gmail.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu,
akpm@linux-foundation.org, torvalds@linux-foundation.org,
ak@suse.de
Subject: Re: [PATCH] x86: Fix DMI out of memory problems
Date: Fri, 21 Dec 2007 14:41:12 +0100 [thread overview]
Message-ID: <20071221134111.GB8222@bingen.suse.de> (raw)
In-Reply-To: <Pine.LNX.4.64.0712181848430.3663@mini.warudkars.net>
On Tue, Dec 18, 2007 at 07:33:00PM -0500, Parag Warudkar wrote:
>
> People with HP Desktops (including me) encounter couple of DMI errors
> during boot - dmi_save_oem_strings_devices: out of memory and dmi_string:
> out of memory.
>
> On some HP desktops the DMI data include OEM strings (type 11) out of which
> only few are meaningful and most other are empty. DMI code religiously
> creates copies of these 27 strings (65ytes each in my case) and goes OOM
> in dmi_string().
>
> If DMI_MAX_DATA is bumped up a little then it goes and fails in
> dmi_save_oem_strings while allocating dmi_devices of sizeof(struct
> dmi_device) corresponding to these strings.
>
> On x86_64 since we cannot use alloc_bootmem this early, the code uses a
FWIW the ff tree has patches to allow "really early allocation" now.
They could be used for this. I didn't implement that for i386 though,
so that would still need some variant of your patch.
Disadvantage right now: e820 memory allocation currently rounds to pages
always. I intend to fix that though because it also wastes memory
with the memnodemap for once.
The forced page rounding was recently added as another bugfix, but that needs
to be reworked.
-Andi
ftp://ftp.firstfloor.org/pub/ak/quilt/patches/early-reserve
ftp://ftp.firstfloor.org/pub/ak/quilt/patches/early-alloc
next prev parent reply other threads:[~2007-12-21 13:41 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 0:33 Parag Warudkar
2007-12-19 10:48 ` Ingo Molnar
2007-12-19 16:48 ` Parag Warudkar
2007-12-19 16:54 ` Ingo Molnar
2007-12-19 17:00 ` Parag Warudkar
2007-12-19 17:06 ` Ingo Molnar
2007-12-19 17:09 ` Parag Warudkar
2007-12-19 17:56 ` Ingo Molnar
2007-12-21 13:41 ` Andi Kleen [this message]
2007-12-21 16:31 ` Parag Warudkar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20071221134111.GB8222@bingen.suse.de \
--to=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=parag.warudkar@gmail.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®