From: Parag Warudkar <parag.warudkar@gmail.com>
To: Andi Kleen <ak@suse.de>
Cc: Parag Warudkar <parag.warudkar@gmail.com>,
linux-kernel@vger.kernel.org, mingo@elte.hu,
akpm@linux-foundation.org, torvalds@linux-foundation.org
Subject: Re: [PATCH] x86: Fix DMI out of memory problems
Date: Fri, 21 Dec 2007 11:31:53 -0500 (EST) [thread overview]
Message-ID: <alpine.LRH.1.00.0712211006290.18697@mini.warudkars.net> (raw)
In-Reply-To: <20071221134111.GB8222@bingen.suse.de>
On Fri, 21 Dec 2007, Andi Kleen wrote:
>
> FWIW the ff tree has patches to allow "really early allocation" now.
> They could be used for this. I didn't implement that for i386 though,
> so that would still need some variant of your patch.
Just to clarify -The allocation failure currently happens only on x86_64 -
on i386 it uses alloc_bootmem and does not fail.
Regardless though this patch is a good idea for both i386 and x86_64 -
there is no point in repeatedly allocating memory for large empty strings
no matter where it comes from, which was the point of this patch.
>
> Disadvantage right now: e820 memory allocation currently rounds to pages
> always. I intend to fix that though because it also wastes memory
> with the memnodemap for once.
>
So looks like currently we have to at least use 4K with these patches -
that would be at least 8 times more than what is actually used after this
patch unless we also fit in some other early alloc in this 4k. I will keep
an eye on the ff tree though - when you get to fix it we can switch all early allocs to use it.
Thanks
Parag
prev parent reply other threads:[~2007-12-21 16:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-19 0:33 Parag Warudkar
2007-12-19 10:48 ` Ingo Molnar
2007-12-19 16:48 ` Parag Warudkar
2007-12-19 16:54 ` Ingo Molnar
2007-12-19 17:00 ` Parag Warudkar
2007-12-19 17:06 ` Ingo Molnar
2007-12-19 17:09 ` Parag Warudkar
2007-12-19 17:56 ` Ingo Molnar
2007-12-21 13:41 ` Andi Kleen
2007-12-21 16:31 ` Parag Warudkar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=alpine.LRH.1.00.0712211006290.18697@mini.warudkars.net \
--to=parag.warudkar@gmail.com \
--cc=ak@suse.de \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®