* [PATCH] Fix broken ip= parsing
@ 2007-12-29 17:08 Thomas Bogendoerfer
2007-12-29 22:54 ` Adrian McMenamin
2007-12-30 2:59 ` David Miller
0 siblings, 2 replies; 3+ messages in thread
From: Thomas Bogendoerfer @ 2007-12-29 17:08 UTC (permalink / raw)
To: linux-kernel, netdev; +Cc: horms, davem
Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing
completly, because ic_enable is never set. The patch below puts
back the way ic_enable was set before.
Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
---
net/ipv4/ipconfig.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/net/ipv4/ipconfig.c b/net/ipv4/ipconfig.c
index 420f56a..4266528 100644
--- a/net/ipv4/ipconfig.c
+++ b/net/ipv4/ipconfig.c
@@ -1440,6 +1440,7 @@ static int __init ip_auto_config_setup(char *addrs)
int num = 0;
ic_set_manually = 1;
+ ic_enable = *addrs;
if (ic_proto_name(addrs))
return 1;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix broken ip= parsing
2007-12-29 17:08 [PATCH] Fix broken ip= parsing Thomas Bogendoerfer
@ 2007-12-29 22:54 ` Adrian McMenamin
2007-12-30 2:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: Adrian McMenamin @ 2007-12-29 22:54 UTC (permalink / raw)
To: Thomas Bogendoerfer; +Cc: linux-kernel, netdev, horms, davem
On 29/12/2007, Thomas Bogendoerfer <tsbogend@alpha.franken.de> wrote:
> Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing
> completly, because ic_enable is never set. The patch below puts
> back the way ic_enable was set before.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
> ---
>
This patch certainly fixes the problem I was having with NFS root - I
had a working setup that stopped (though at the same time as I updated
my Busybox setup so I thought this was my mistake).
Please apply.
Tested by: Adrian McMenamin <adrian@mcmen.demon.co.uk>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Fix broken ip= parsing
2007-12-29 17:08 [PATCH] Fix broken ip= parsing Thomas Bogendoerfer
2007-12-29 22:54 ` Adrian McMenamin
@ 2007-12-30 2:59 ` David Miller
1 sibling, 0 replies; 3+ messages in thread
From: David Miller @ 2007-12-30 2:59 UTC (permalink / raw)
To: tsbogend; +Cc: linux-kernel, netdev, horms
From: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
Date: Sat, 29 Dec 2007 18:08:49 +0100 (CET)
> Commit a6c05c3d064dbb83be88cba3189beb5db9d2dfc3 breaks ip= parsing
> completly, because ic_enable is never set. The patch below puts
> back the way ic_enable was set before.
>
> Signed-off-by: Thomas Bogendoerfer <tsbogend@alpha.franken.de>
I already have this exact patch in my net-2.6 tree from Simon.
Thanks.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2007-12-30 3:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-29 17:08 [PATCH] Fix broken ip= parsing Thomas Bogendoerfer
2007-12-29 22:54 ` Adrian McMenamin
2007-12-30 2:59 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®