* why do we call clear_active_flags in shrink_inactive_list ?
@ 2007-12-30 7:32 minchan Kim
2008-01-02 23:53 ` Rik van Riel
0 siblings, 1 reply; 2+ messages in thread
From: minchan Kim @ 2007-12-30 7:32 UTC (permalink / raw)
To: linux-mm; +Cc: linux-kernel
In 2.6.23's shrink_inactive_list function, why do we have to call
clear_active_flags after isolate_lru_pages call ?
IMHO, If it call isolate_lru_pages with "zone->inactive_list", It can
be sure that it is not PG_active. So I think It is unnecessary calling
clear_active_flags. Nonetheless, Why do we have to recheck PG_active
flags wich clear_active_flags.
If it is right, which case it happens that page is set to be PG_active ?
--
Thanks,
barrios
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: why do we call clear_active_flags in shrink_inactive_list ?
2007-12-30 7:32 why do we call clear_active_flags in shrink_inactive_list ? minchan Kim
@ 2008-01-02 23:53 ` Rik van Riel
0 siblings, 0 replies; 2+ messages in thread
From: Rik van Riel @ 2008-01-02 23:53 UTC (permalink / raw)
To: minchan Kim; +Cc: linux-mm, linux-kernel
On Sun, 30 Dec 2007 16:32:42 +0900
"minchan Kim" <barrioskmc@gmail.com> wrote:
> In 2.6.23's shrink_inactive_list function, why do we have to call
> clear_active_flags after isolate_lru_pages call ?
> IMHO, If it call isolate_lru_pages with "zone->inactive_list", It can
> be sure that it is not PG_active.
If we call isolate_lru_pages with mode = ISOLATE_BOTH, then it
can return both active and inactive pages and the calling function
has to be able to deal with both kinds of pages.
ISOLATE_BOTH is used when the kernel is trying to defragment memory,
for larger physically contiguous allocations.
--
All rights reversed.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-02 23:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2007-12-30 7:32 why do we call clear_active_flags in shrink_inactive_list ? minchan Kim
2008-01-02 23:53 ` Rik van Riel
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®