From: Herbert Xu <herbert@gondor.apana.org.au>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
m.kozlowski@tuxland.pl, davem@davemloft.net,
sparclinux@vger.kernel.org, netdev@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: sparc oops in ip_fast_csum
Date: Sun, 6 Jan 2008 12:03:59 +1100 [thread overview]
Message-ID: <20080106010358.GA2991@gondor.apana.org.au> (raw)
In-Reply-To: <Pine.LNX.4.64.0801060156410.14194@fbirervta.pbzchgretzou.qr>
On Sun, Jan 06, 2008 at 01:57:13AM +0100, Jan Engelhardt wrote:
>
> >@@ -304,7 +305,8 @@ static int raw_send_hdrinc(struct sock *sk, void *from, size_t length,
> > goto error_fault;
> >
> > /* We don't modify invalid header */
> >- if (length >= sizeof(*iph) && iph->ihl * 4U <= length) {
> >+ iphlen = iph->ihl * 4;
> >+ if (iphlen >= sizeof(*iph) && iphlen <= length) {
>
> Humm, this could use ip_hdrlen(skb) :-)
That would not necessarily be an improvement since we'd have to reload
the values from skb.
Cheers,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2008-01-06 1:04 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-04 17:37 Mariusz Kozlowski
2008-01-05 9:44 ` Al Viro
2008-01-06 0:22 ` Herbert Xu
2008-01-06 0:57 ` Jan Engelhardt
2008-01-06 1:03 ` Herbert Xu [this message]
2008-01-06 2:02 ` Al Viro
2008-01-06 4:14 ` Herbert Xu
2008-01-14 6:09 ` Patrick McHardy
2008-01-14 6:19 ` David Miller
2008-01-06 7:15 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080106010358.GA2991@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
--cc=m.kozlowski@tuxland.pl \
--cc=netdev@vger.kernel.org \
--cc=sparclinux@vger.kernel.org \
--cc=viro@ZenIV.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®