* [PATCH] Label x86 do_fork_idle() with __cpuinit
@ 2008-01-08 11:23 David Howells
2008-01-08 11:27 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: David Howells @ 2008-01-08 11:23 UTC (permalink / raw)
To: sam, ariveira, torvalds, akpm; +Cc: linux-kernel, dhowells
Label x86 do_fork_idle() with __cpuinit to avoid getting linker warnings when
it references fork_idle(). Also make it static.
Signed-off-by: David Howells <dhowells@redhat.com>
---
arch/x86/kernel/smpboot_64.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/smpboot_64.c b/arch/x86/kernel/smpboot_64.c
index 500670c..aaf4e12 100644
--- a/arch/x86/kernel/smpboot_64.c
+++ b/arch/x86/kernel/smpboot_64.c
@@ -526,7 +526,7 @@ struct create_idle {
int cpu;
};
-void do_fork_idle(struct work_struct *work)
+static void __cpuinit do_fork_idle(struct work_struct *work)
{
struct create_idle *c_idle =
container_of(work, struct create_idle, work);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] Label x86 do_fork_idle() with __cpuinit
2008-01-08 11:23 [PATCH] Label x86 do_fork_idle() with __cpuinit David Howells
@ 2008-01-08 11:27 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-01-08 11:27 UTC (permalink / raw)
To: David Howells
Cc: sam, ariveira, torvalds, akpm, linux-kernel, Thomas Gleixner
* David Howells <dhowells@redhat.com> wrote:
> Label x86 do_fork_idle() with __cpuinit to avoid getting linker
> warnings when it references fork_idle(). Also make it static.
Thomas is already working on this and has a patch for this and for other
linker warnings.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-08 11:28 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-08 11:23 [PATCH] Label x86 do_fork_idle() with __cpuinit David Howells
2008-01-08 11:27 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome