mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Evgeniy Polyakov <johnpol@2ka.mipt.ru>
To: Alexey Dobriyan <adobriyan@sw.ru>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	linux-kernel@vger.kernel.org, devel@openvz.org
Subject: Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
Date: Tue, 8 Jan 2008 17:53:40 +0300	[thread overview]
Message-ID: <20080108145340.GA1383@2ka.mipt.ru> (raw)
In-Reply-To: <20080108084434.GB6209@localhost.sw.ru>

Hi.

On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan (adobriyan@sw.ru) wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
> 
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>

Well, I have no problem with the patch, although do not see any gain
in it :)
I usually prefer to call members the same in container usage, since I
always forget where each one should be placed.

-- 
	Evgeniy Polyakov

  reply	other threads:[~2008-01-08 14:54 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-08  8:44 Alexey Dobriyan
2008-01-08 14:53 ` Evgeniy Polyakov [this message]
2008-01-08 20:47 ` Herbert Xu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080108145340.GA1383@2ka.mipt.ru \
    --to=johnpol@2ka.mipt.ru \
    --cc=adobriyan@sw.ru \
    --cc=devel@openvz.org \
    --cc=herbert@gondor.apana.org.au \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome