* [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
@ 2008-01-08 8:44 Alexey Dobriyan
2008-01-08 14:53 ` Evgeniy Polyakov
2008-01-08 20:47 ` Herbert Xu
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2008-01-08 8:44 UTC (permalink / raw)
To: Evgeniy Polyakov; +Cc: Herbert Xu, linux-kernel, devel
[PATCH -mm 2/4] hifn_795x: fixup container_of() usage
Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
---
drivers/crypto/hifn_795x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/crypto/hifn_795x.c
+++ b/drivers/crypto/hifn_795x.c
@@ -664,7 +664,7 @@ struct hifn_context
atomic_t sg_num;
};
-#define crypto_alg_to_hifn(alg) container_of(alg, struct hifn_crypto_alg, alg)
+#define crypto_alg_to_hifn(a) container_of(a, struct hifn_crypto_alg, alg)
static inline u32 hifn_read_0(struct hifn_device *dev, u32 reg)
{
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
2008-01-08 8:44 [PATCH -mm 2/4] hifn_795x: fixup container_of() usage Alexey Dobriyan
@ 2008-01-08 14:53 ` Evgeniy Polyakov
2008-01-08 20:47 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Evgeniy Polyakov @ 2008-01-08 14:53 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Herbert Xu, linux-kernel, devel
Hi.
On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan (adobriyan@sw.ru) wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Well, I have no problem with the patch, although do not see any gain
in it :)
I usually prefer to call members the same in container usage, since I
always forget where each one should be placed.
--
Evgeniy Polyakov
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
2008-01-08 8:44 [PATCH -mm 2/4] hifn_795x: fixup container_of() usage Alexey Dobriyan
2008-01-08 14:53 ` Evgeniy Polyakov
@ 2008-01-08 20:47 ` Herbert Xu
1 sibling, 0 replies; 3+ messages in thread
From: Herbert Xu @ 2008-01-08 20:47 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Evgeniy Polyakov, linux-kernel, devel
On Tue, Jan 08, 2008 at 11:44:34AM +0300, Alexey Dobriyan wrote:
> [PATCH -mm 2/4] hifn_795x: fixup container_of() usage
>
> Signed-off-by: Alexey Dobriyan <adobriyan@sw.ru>
Patch applied. Thanks.
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-01-08 20:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-08 8:44 [PATCH -mm 2/4] hifn_795x: fixup container_of() usage Alexey Dobriyan
2008-01-08 14:53 ` Evgeniy Polyakov
2008-01-08 20:47 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome