mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <ak@suse.de>
To: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>
Cc: Ingo Molnar <mingo@elte.hu>, David Miller <davem@davemloft.net>,
	hch@lst.de, airlied@linux.ie, akpm@linux-foundation.org,
	torvalds@linux-foundation.org, pq@iki.fi, jbeulich@novell.com,
	linux-kernel@vger.kernel.org,
	Ananth N Mavinakayanahalli <ananth@in.ibm.com>,
	Masami Hiramatsu <mhiramat@redhat.com>
Subject: Re: [PATCH] Revert "x86: optimize page faults like all other achitectures and kill notifier cruft"
Date: Wed, 9 Jan 2008 20:07:13 +0100	[thread overview]
Message-ID: <200801092007.13414.ak@suse.de> (raw)
In-Reply-To: <20080109165254.GA4912@Krystal>


> Probing vmalloc faults is _really_ tricky : it also implies that the
> handler (let's call it probe) connected to the probe point (marker or
> kprobe) should _never_ cause a vmalloc page fault, 

That is why vmalloc_sync_all() was invented. It might make sense
to just call that on kprobe registration.

But I agree the other problems makes it a bad idea.

I think the better solution is to keep the notifier, but make 
it cheaper (e.g. by using constant patching ...)

-Andi

  reply	other threads:[~2008-01-09 19:07 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09  2:34 Dave Airlie
2008-01-09  2:37 ` Andi Kleen
2008-01-09  3:06 ` Andrew Morton
2008-01-09  3:17   ` Dave Airlie
2008-01-09  3:29     ` Andrew Morton
2008-01-09  3:55       ` Dave Airlie
2008-01-09  7:19         ` Christoph Hellwig
2008-01-09  7:23           ` David Miller
2008-01-09 10:41             ` Ingo Molnar
2008-01-09 16:52               ` Mathieu Desnoyers
2008-01-09 19:07                 ` Andi Kleen [this message]
2008-01-09 20:01               ` Pekka Paalanen
2008-01-09 20:08                 ` Andi Kleen
2008-01-09  4:17       ` Andi Kleen
2008-01-09  9:12       ` Jan Beulich
2008-01-09 15:18     ` Arjan van de Ven
2008-01-09 15:21       ` Andi Kleen
2008-01-09 15:26         ` Ingo Molnar
2008-01-09  7:17 ` Christoph Hellwig
2008-01-09  7:22   ` David Miller
2008-01-09 13:19     ` Jiri Kosina
2008-01-09 13:48       ` David Miller
2008-01-09 14:23     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200801092007.13414.ak@suse.de \
    --to=ak@suse.de \
    --cc=airlied@linux.ie \
    --cc=akpm@linux-foundation.org \
    --cc=ananth@in.ibm.com \
    --cc=davem@davemloft.net \
    --cc=hch@lst.de \
    --cc=jbeulich@novell.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mathieu.desnoyers@polymtl.ca \
    --cc=mhiramat@redhat.com \
    --cc=mingo@elte.hu \
    --cc=pq@iki.fi \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome