mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Jan Beulich" <jbeulich@novell.com>
To: "Andrew Morton" <akpm@linux-foundation.org>
Cc: <mingo@elte.hu>, <pq@iki.fi>, <torvalds@linux-foundation.org>,
	"Dave Airlie" <airlied@linux.ie>, <hch@lst.de>, <ak@suse.de>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] Revert "x86: optimize page faults like all other achitectures and kill notifier cruft"
Date: Wed, 09 Jan 2008 09:12:16 +0000	[thread overview]
Message-ID: <47849E00.76E4.0078.0@novell.com> (raw)
In-Reply-To: <20080108192951.a4dc394f.akpm@linux-foundation.org>

[-- Attachment #1: Type: text/plain, Size: 381 bytes --]

>That change has been in the mainline tree for nearly three months.  All
>these affected parties have left it until the eve of 2.6.24 to actually
>tell us about it.  This is causing me sympathy problems :(

Not true - I complained about this on Dec 3rd (attached), with the result of
not getting a response from anyone but Andi (agreeing to restore these
notifiers).

Jan

[-- Attachment #2: Type: message/rfc822, Size: 1620 bytes --]

From: "Jan Beulich" <jbeulich@novell.com>
To: <akpm@linux-foundation.org>,<torvalds@linux-foundation.org>, <hch@lst.de>
Cc: <ananth@in.ibm.com>,<prasanna@in.ibm.com>, <anil.s.keshavamurthy@intel.com>, <ak@suse.de>, <linux-arch@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: x86: optimize page faults like all other achitectures and kill notifier cruft
Date: Mon, 03 Dec 2007 13:31:07 +0000

Ever since I started to try to get at least some fundamental infrastructure
pieces merged for using NLKD on Linux I was told that direct calls out of
exception handlers for the sake of an individual (and perhaps even small)
sub-system is undesirable.

Making the exception notifiers report the right (correct) information (and,
specific to x86, ensuring they get called in the right place) was one of the
fundamental things, and just now I see that this is being reverted for (in
my eyes) no good reason: Instead of adding direct calls to x86, all the
other architectures should have followed the notifier model in order for
the infrastructure to be usable by external components, especially if
these aren't allowed into the kernel.

Am I to conclude that replacing direct calls elsewhere in the tree (in order
to e.g. avoid all kinds of small sub-components leaving their footprint in
core files like kernel/fork.c) is no longer a desirable goal, thereby making
it almost impossible to ever host a kernel debugger *without* having to
patch core files.

Thanks, Jan


  parent reply	other threads:[~2008-01-09  9:12 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-01-09  2:34 Dave Airlie
2008-01-09  2:37 ` Andi Kleen
2008-01-09  3:06 ` Andrew Morton
2008-01-09  3:17   ` Dave Airlie
2008-01-09  3:29     ` Andrew Morton
2008-01-09  3:55       ` Dave Airlie
2008-01-09  7:19         ` Christoph Hellwig
2008-01-09  7:23           ` David Miller
2008-01-09 10:41             ` Ingo Molnar
2008-01-09 16:52               ` Mathieu Desnoyers
2008-01-09 19:07                 ` Andi Kleen
2008-01-09 20:01               ` Pekka Paalanen
2008-01-09 20:08                 ` Andi Kleen
2008-01-09  4:17       ` Andi Kleen
2008-01-09  9:12       ` Jan Beulich [this message]
2008-01-09 15:18     ` Arjan van de Ven
2008-01-09 15:21       ` Andi Kleen
2008-01-09 15:26         ` Ingo Molnar
2008-01-09  7:17 ` Christoph Hellwig
2008-01-09  7:22   ` David Miller
2008-01-09 13:19     ` Jiri Kosina
2008-01-09 13:48       ` David Miller
2008-01-09 14:23     ` Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=47849E00.76E4.0078.0@novell.com \
    --to=jbeulich@novell.com \
    --cc=airlied@linux.ie \
    --cc=ak@suse.de \
    --cc=akpm@linux-foundation.org \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=pq@iki.fi \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome