From: Sam Ravnborg <sam@ravnborg.org>
To: Johannes Berg <johannes@sipsolutions.net>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel list <linux-kernel@vger.kernel.org>
Subject: Re: hrtimer.c devinit vs. cpuinit
Date: Tue, 15 Jan 2008 13:22:08 +0100 [thread overview]
Message-ID: <20080115122208.GA17122@uranus.ravnborg.org> (raw)
In-Reply-To: <1200357010.5887.72.camel@johannes.berg>
On Tue, Jan 15, 2008 at 01:30:10AM +0100, Johannes Berg wrote:
> Hi,
>
> Looking through hrtimer.c I noticed
>
> static void __devinit init_hrtimers_cpu(int cpu)
>
> static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
> unsigned long action, void *hcpu)
>
>
> Couldn't the first be __cpuinit as well?
As the only user of init_hrtimers_cpu is __cpuinit then it is a bug
that init_hrtimers_cpu is __devinit today.
So you are correct and it must be fixed.
Sam
prev parent reply other threads:[~2008-01-15 12:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-15 0:30 Johannes Berg
2008-01-15 12:22 ` Sam Ravnborg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080115122208.GA17122@uranus.ravnborg.org \
--to=sam@ravnborg.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®