* hrtimer.c devinit vs. cpuinit
@ 2008-01-15 0:30 Johannes Berg
2008-01-15 12:22 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Johannes Berg @ 2008-01-15 0:30 UTC (permalink / raw)
To: Thomas Gleixner; +Cc: Linux Kernel list
[-- Attachment #1: Type: text/plain, Size: 301 bytes --]
Hi,
Looking through hrtimer.c I noticed
static void __devinit init_hrtimers_cpu(int cpu)
static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
unsigned long action, void *hcpu)
Couldn't the first be __cpuinit as well?
johannes
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: hrtimer.c devinit vs. cpuinit
2008-01-15 0:30 hrtimer.c devinit vs. cpuinit Johannes Berg
@ 2008-01-15 12:22 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2008-01-15 12:22 UTC (permalink / raw)
To: Johannes Berg; +Cc: Thomas Gleixner, Linux Kernel list
On Tue, Jan 15, 2008 at 01:30:10AM +0100, Johannes Berg wrote:
> Hi,
>
> Looking through hrtimer.c I noticed
>
> static void __devinit init_hrtimers_cpu(int cpu)
>
> static int __cpuinit hrtimer_cpu_notify(struct notifier_block *self,
> unsigned long action, void *hcpu)
>
>
> Couldn't the first be __cpuinit as well?
As the only user of init_hrtimers_cpu is __cpuinit then it is a bug
that init_hrtimers_cpu is __devinit today.
So you are correct and it must be fixed.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-01-15 12:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-15 0:30 hrtimer.c devinit vs. cpuinit Johannes Berg
2008-01-15 12:22 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®