mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 5/5] sound: fix caiaq section mismatches
@ 2008-01-15 21:25 Randy Dunlap
  2008-01-16 13:57 ` Takashi Iwai
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-01-15 21:25 UTC (permalink / raw)
  To: lkml, linux-sound; +Cc: perex, akpm, samr

From: Randy Dunlap <randy.dunlap@oracle.com>

Fix section mismatch in caiaq: these __devinit functions can be
called at any time so they should not be __devinit.

WARNING: vmlinux.o(.text+0x10a8dae): Section mismatch: reference to .init.text:snd_usb_caiaq_audio_init (between 'setup_card' and 'create_card')
WARNING: vmlinux.o(.text+0x10a8dd6): Section mismatch: reference to .init.text:snd_usb_caiaq_midi_init (between 'setup_card' and 'create_card')

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
 sound/usb/caiaq/caiaq-audio.c |    2 +-
 sound/usb/caiaq/caiaq-midi.c  |    2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

--- linux-2.6.24-rc7-git7.orig/sound/usb/caiaq/caiaq-audio.c
+++ linux-2.6.24-rc7-git7/sound/usb/caiaq/caiaq-audio.c
@@ -606,7 +606,7 @@ static void free_urbs(struct urb **urbs)
 	kfree(urbs);
 }
 
-int __devinit snd_usb_caiaq_audio_init(struct snd_usb_caiaqdev *dev)
+int snd_usb_caiaq_audio_init(struct snd_usb_caiaqdev *dev)
 {
 	int i, ret;
 
--- linux-2.6.24-rc7-git7.orig/sound/usb/caiaq/caiaq-midi.c
+++ linux-2.6.24-rc7-git7/sound/usb/caiaq/caiaq-midi.c
@@ -124,7 +124,7 @@ void snd_usb_caiaq_midi_handle_input(str
 	snd_rawmidi_receive(dev->midi_receive_substream, buf, len);
 }
 
-int __devinit snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *device)
+int snd_usb_caiaq_midi_init(struct snd_usb_caiaqdev *device)
 {
 	int ret;
 	struct snd_rawmidi *rmidi;

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 5/5] sound: fix caiaq section mismatches
  2008-01-15 21:25 [PATCH 5/5] sound: fix caiaq section mismatches Randy Dunlap
@ 2008-01-16 13:57 ` Takashi Iwai
  0 siblings, 0 replies; 2+ messages in thread
From: Takashi Iwai @ 2008-01-16 13:57 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, linux-sound, perex, akpm, samr

At Tue, 15 Jan 2008 13:25:46 -0800,
Randy Dunlap wrote:
> 
> From: Randy Dunlap <randy.dunlap@oracle.com>
> 
> Fix section mismatch in caiaq: these __devinit functions can be
> called at any time so they should not be __devinit.
> 
> WARNING: vmlinux.o(.text+0x10a8dae): Section mismatch: reference to .init.text:snd_usb_caiaq_audio_init (between 'setup_card' and 'create_card')
> WARNING: vmlinux.o(.text+0x10a8dd6): Section mismatch: reference to .init.text:snd_usb_caiaq_midi_init (between 'setup_card' and 'create_card')
> 
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>

Thanks, applied all 5 patches to ALSA tree now.


Takashi

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-01-16 13:57 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-01-15 21:25 [PATCH 5/5] sound: fix caiaq section mismatches Randy Dunlap
2008-01-16 13:57 ` Takashi Iwai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®