* [PATCH] x86: rename module scx200_32 to scx200
@ 2008-02-03 12:35 Sam Ravnborg
2008-02-03 12:36 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Sam Ravnborg @ 2008-02-03 12:35 UTC (permalink / raw)
To: Ingo Molnar, LKML; +Cc: Thomas Gleixner, H. Peter Anvin
The module scx200 were renamed to scx200_32 by the
merge of the 32 and 64 bit x86 arch trees.
Keep the _32 prefix on the .c file as it is 32 bit
specific and fix the module name in the Makefile.
Signed-off-by: Sam Ravnborg <sam@ravnborg.org>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
---
Found during audit for this issue.
One other file uses module_init: vmiclock_32.c
But this file cannot be build as a module with present
configuration.
Build time tested only but obviously correct.
Sam
diff --git a/arch/x86/kernel/Makefile b/arch/x86/kernel/Makefile
index 6f81300..55106aa 100644
--- a/arch/x86/kernel/Makefile
+++ b/arch/x86/kernel/Makefile
@@ -74,7 +74,8 @@ ifdef CONFIG_INPUT_PCSPKR
obj-y += pcspeaker.o
endif
-obj-$(CONFIG_SCx200) += scx200_32.o
+obj-$(CONFIG_SCx200) += scx200.o
+scx200-y += scx200_32.o
###
# 64 bit specific files
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] x86: rename module scx200_32 to scx200
2008-02-03 12:35 [PATCH] x86: rename module scx200_32 to scx200 Sam Ravnborg
@ 2008-02-03 12:36 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-02-03 12:36 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: LKML, Thomas Gleixner, H. Peter Anvin
* Sam Ravnborg <sam@ravnborg.org> wrote:
> The module scx200 were renamed to scx200_32 by the merge of the 32 and
> 64 bit x86 arch trees.
>
> Keep the _32 prefix on the .c file as it is 32 bit specific and fix
> the module name in the Makefile.
thanks Sam for auditing for _32 module renamess - applied.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-03 12:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-03 12:35 [PATCH] x86: rename module scx200_32 to scx200 Sam Ravnborg
2008-02-03 12:36 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®