Re: - typhoon-section-fix.patch removed from -mm tree

Re: - typhoon-section-fix.patch removed from -mm tree

[Sam Ravnborg]

On Thu, Feb 07, 2008 at 02:30:08PM -0800, akpm@linux-foundation.org wrote:
> 
> The patch titled
>      typhoon section fix
> has been removed from the -mm tree.  Its filename was
>      typhoon-section-fix.patch
> 
> This patch was dropped because I just remembered __devexitconst :(

But powerpc is subtle and I foresee that we have to kill __devinitconst
and friends soonish.
The problem is that despite data being const the compiler does not
always mark the section const.
So we will see a lot of the errors you see for powerpc now
that we unconditionally specify a section.

Previously this inconsistentcy were hidden by the fact that powerpc tagets
seldom were build without CONFIG_HOTPLUG=y.

So the patches are correct.
Tomorrow I hope to do a patch that kill __devinitconst :-(

	Sam

> 
> The current -mm tree may be found at http://userweb.kernel.org/~akpm/mmotm/
> 
> ------------------------------------------------------
> Subject: typhoon section fix
> From: Andrew Morton <akpm@linux-foundation.org>
> 
> gcc-3.4.4 on powerpc:
> 
> drivers/net/typhoon.c:137: error: version causes a section type conflict
> 
> Cc: Jeff Garzik <jeff@garzik.org>
> Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
> ---
> 
>  drivers/net/typhoon.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff -puN drivers/net/typhoon.c~typhoon-section-fix drivers/net/typhoon.c
> --- a/drivers/net/typhoon.c~typhoon-section-fix
> +++ a/drivers/net/typhoon.c
> @@ -134,7 +134,7 @@ static const int multicast_filter_limit 
>  #include "typhoon.h"
>  #include "typhoon-firmware.h"
>  
> -static const char version[] __devinitdata =
> +static char version[] __devinitdata =
>      "typhoon.c: version " DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
>  
>  MODULE_AUTHOR("David Dillow <dave@thedillows.org>");
> _
> 
> Patches currently in -mm which might be from akpm@linux-foundation.org are
> 
> origin.patch
> vfs-swap-do_ioctl-and-vfs_ioctl-names.patch
> cgroup-simplify-space-stripping.patch
> memory-controller-memory-accounting-v7.patch
> memory-controller-add-per-container-lru-and-reclaim-v7.patch
> memory-controller-oom-handling-v7.patch
> memory-controller-add-switch-to-control-what-type-of-pages-to-limit-v7.patch
> memcontrol-move-mm_cgroup-to-header-file.patch
> memcontrol-move-oom-task-exclusion-to-tasklist.patch
> memory-cgroup-enhancements-fix-zone-handling-in-try_to_free_mem_cgroup_page.patch
> memory-cgroup-enhancements-add-status-accounting-function-for-memory-cgroup.patch
> memory-cgroup-enhancements-add-memorystat-file.patch
> per-zone-and-reclaim-enhancements-for-memory-controller-take-3-remember-reclaim-priority-in-memory-cgroup.patch
> per-zone-and-reclaim-enhancements-for-memory-controller-take-3-modifies-vmscanc-for-isolate-globa-cgroup-lru-activity.patch
> cgroups-mechanism-to-process-each-task-in-a-cgroup.patch
> hotplug-cpu-move-tasks-in-empty-cpusets-to-parent.patch
> cpusets-update_cpumask-revision.patch
> drivers-edac-add-marvell-mv64x60-driver.patch
> introduce-flags-for-reserve_bootmem.patch
> iget-stop-affs-from-using-iget-and-read_inode-try.patch
> iget-stop-efs-from-using-iget-and-read_inode-try.patch
> iget-stop-ext2-from-using-iget-and-read_inode-try.patch
> iget-stop-ext3-from-using-iget-and-read_inode-try.patch
> iget-stop-freevxfs-from-using-iget-and-read_inode.patch
> iget-stop-the-minix-filesystem-from-using-iget-and.patch
> iget-stop-procfs-from-using-iget-and-read_inode.patch
> iget-stop-qnx4-from-using-iget-and-read_inode-try.patch
> iget-stop-romfs-from-using-iget-and-read_inode.patch
> iget-stop-the-sysv-filesystem-from-using-iget-and.patch
> iget-stop-ufs-from-using-iget-and-read_inode-try.patch
> iget-stop-hostfs-from-using-iget-and-read_inode.patch
> git-acpi.patch
> acpi-enable-c3-power-state-on-dell-inspiron-8200.patch
> small-acpica-extension-to-be-able-to-store-the-name-of.patch
> acpi-backlight-reset-brightness-on-resume.patch
> git-alsa-build-fix.patch
> git-audit-printk-warning-fix.patch
> git-cifs.patch
> git-cpufreq.patch
> revert-agk-dm-dm-loop.patch
> drivers-pcmcia-i82092c-fix-up-after-pci_bus_region-changes.patch
> git-drm.patch
> git-drm-fix.patch
> drm-convert-from-nopage-to-fault.patch
> drivers-media-video-em28xx-em28xx-corec-fix-use-of-potentially-uninitialized-variable.patch
> adt7473-new-driver-for-analog-devices-adt7473-sensor-chip.patch
> revert-git-hrt.patch
> git-input.patch
> drivers-input-touchscreen-ads7846c-fix-uninitialized-var-warning.patch
> git-kvm.patch
> memstick-initial-commit-for-sony-memorystick-support-fix-2.patch
> memstick-disable-busted-code.patch
> git-mmc.patch
> git-mtd.patch
> drivers-mtd-maps-physmapc-fix-compile-remove-ifdef.patch
> typhoon-section-fix.patch
> typhoon-section-fix-fix.patch
> natsemi-section-fix.patch
> bnx2x-section-fix.patch
> bnx2x-section-fix-fix.patch
> bnx2c-section-fix.patch
> bnx2c-section-fix-fix.patch
> via-velocity-section-fix.patch
> starfire-secton-fix.patch
> starfire-secton-fix-fix.patch
> pppol2tp-fix-printk-warnings.patch
> drivers-net-dm9000c-vague-probably-wrong-build-fix.patch
> update-smc91x-driver-with-arm-versatile-board-info.patch
> git-backlight.patch
> cleanup-gregkh-pci-pci-fix-bus-resource-assignment-on-32-bits-with-64b-resources.patch
> quirks-set-en-bit-of-msi-mapping-for-devices-onht-based-nvidia-platform.patch
> x86-validate-against-acpi-motherboard-resources.patch
> git-sched.patch
> git-sched-fix-git-conflicts.patch
> git-sh.patch
> git-scsi-misc.patch
> scsi-aic94xx-cleanups.patch
> libsas-convert-ata-bridge-to-use-new-eh.patch
> git-unionfs.patch
> drivers-usb-storage-sddr55c-fix-uninitialized-var-warnings.patch
> usb-ohci-sm501-driver-v2-fix.patch
> drivers-usb-serial-io_tic-remove-pointless-eye-candy-in-debug-statements.patch
> 9p-fix-p9_printfcall-export.patch
> git-watchdog.patch
> git-watchdog-fixup.patch
> git-ipwireless_cs.patch
> git-x86.patch
> pci-dont-load-acpi_php-when-acpi-is-disabled.patch
> x86-amd-thermal-interrupt-support.patch
> x86-mmconf-enable-mcfg-early.patch
> git-xtensa.patch
> git-slub.patch
> vmscan-give-referenced-active-and-unmapped-pages-a-second-trip-around-the-lru.patch
> vm-dont-run-touch_buffer-during-buffercache-lookups.patch
> kill-filp_open.patch
> rename-open_namei-to-open_pathname.patch
> r-o-bind-mounts-elevate-write-count-during-entire-ncp_ioctl.patch
> r-o-bind-mounts-elevate-write-count-for-do_utimes.patch
> r-o-bind-mounts-elevate-write-count-for-some-ioctls.patch
> r-o-bind-mounts-elevate-write-count-opened-files.patch
> r-o-bind-mounts-nfs-check-mnt-instead-of-superblock-directly.patch
> r-o-bind-mounts-track-number-of-mount-writers.patch
> keep-track-of-mnt_writer-state-of-struct-file.patch
> iget-stop-unionfs-from-using-iget-and-read_inode-fix-2.patch
> embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-checkpatch-fixes.patch
> embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-vs-git-unionfs.patch
> embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-cifs-fix.patch
> embed-a-struct-path-into-struct-nameidata-instead-of-nd-dentrymnt-smack-fix.patch
> introduce-path_put-cifs-fix.patch
> one-less-parameter-to-__d_path-checkpatch-fixes.patch
> d_path-use-struct-path-in-struct-avc_audit_data-checkpatch-fixes.patch
> d_path-make-get_dcookie-use-a-struct-path-argument-checkpatch-fixes.patch
> use-struct-path-in-struct-svc_export-checkpatch-fixes.patch
> d_path-make-d_path-use-a-struct-path-fix.patch
> cleanup-the-code-managed-with-the-user_ns-option-checkpatch-fixes.patch
> cleanup-the-code-managed-with-pid_ns-option-checkpatch-fixes.patch
> proc-detect-duplicate-names-on-registration-fix.patch
> proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-checkpatch-fixes.patch
> proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix.patch
> proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix-2.patch
> proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-fix-3.patch
> proc-seqfile-convert-proc_pid_status-to-properly-handle-pid-namespaces-nommu-fix.patch
> proc-fix-openless-usage-due-to-proc_fops-flip-checkpatch-fixes.patch
> intel-iommu-fault_reason_index_cleanuppatch-fix.patch
> modules-make-module_address_lookup-safe-fix.patch
> wait_task_stopped-simplify-and-fix-races-with-sigcont-sigkill-untrace-fix.patch
> pid-sys_wait-fixes-v2-checkpatch-fixes.patch
> aout-suppress-aout-library-support-if-config_arch_supports_aout-vs-git-x86.patch
> aout-suppress-aout-library-support-if-config_arch_supports_aout-vs-sanitize-the-type-of-struct-useru_ar0.patch
> aout-remove-unnecessary-inclusions-of-asm-linux-aouth-alpha-fix.patch
> mn10300-add-the-mn10300-am33-architecture-to-the-kernel-fix.patch
> rewrite-rd-fixes.patch
> fs-remove-fastcall-it-is-always-empty-checkpatch-fixes.patch
> kernel-remove-fastcall-in-kernel-checkpatch-fixes.patch
> lib-remove-fastcall-from-lib-checkpatch-fixes.patch
> remove-fastcall-from-linux-include-checkpatch-fixes.patch
> constify-tables-in-kernel-sysctl_checkc-fix.patch
> aoe-statically-initialise-devlist_lock.patch
> xfs-convert-bex_add-to-bex_add_cpu-new-common-api-fix.patch
> ufs-fix-symlink-creation-on-ufs2-fix.patch
> libfs-allow-error-return-from-simple-attributes-fix.patch
> fs-hfsplus-unicodec-fix-uninitialized-var-warning.patch
> fs-afs-securityc-fix-uninitialized-var-warning.patch
> mount-options-fix-tmpfs-fix.patch
> char-applicom-use-pci_match_id-fix.patch
> add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them-fix.patch
> add-new-string-functions-strict_strto-and-convert-kernel-params-to-use-them-fix-2.patch
> procfs-task-exe-symlink-fix.patch
> reiser4.patch
> jens-broke-reiser4patch-added-to-mm-tree.patch
> page-owner-tracking-leak-detector.patch
> nr_blockdev_pages-in_interrupt-warning.patch
> slab-leaks3-default-y.patch
> profile-likely-unlikely-macros-fix.patch
> put_bh-debug.patch
> shrink_slab-handle-bad-shrinkers.patch
> getblk-handle-2tb-devices.patch
> getblk-handle-2tb-devices-fix.patch
> undeprecate-pci_find_device.patch
> w1-build-fix.patch
> 
> -
> To unsubscribe from this list: send the line "unsubscribe mm-commits" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: - typhoon-section-fix.patch removed from -mm tree

[Andrew Morton]

On Thu, 7 Feb 2008 23:36:01 +0100
Sam Ravnborg <sam@ravnborg.org> wrote:

> On Thu, Feb 07, 2008 at 02:30:08PM -0800, akpm@linux-foundation.org wrote:
> > 
> > The patch titled
> >      typhoon section fix
> > has been removed from the -mm tree.  Its filename was
> >      typhoon-section-fix.patch
> > 
> > This patch was dropped because I just remembered __devexitconst :(
> 
> But powerpc is subtle and I foresee that we have to kill __devinitconst
> and friends soonish.
> The problem is that despite data being const the compiler does not
> always mark the section const.
> So we will see a lot of the errors you see for powerpc now
> that we unconditionally specify a section.
> 
> Previously this inconsistentcy were hidden by the fact that powerpc tagets
> seldom were build without CONFIG_HOTPLUG=y.
> 
> So the patches are correct.
> Tomorrow I hope to do a patch that kill __devinitconst :-(
> 

hrm, OK.

> >  
> > -static const char version[] __devinitdata =
> > +static char version[] __devinitdata =
> >      "typhoon.c: version " DRV_MODULE_VERSION " (" DRV_MODULE_RELDATE ")\n";
> >  

but chances are that in a year's time someone will come along and helpfully
make this const again.  Maybe we should annotate such sites with

#define cant_make_me_const_ask_sam_why /**/

to avoid this..