From: Grant Grundler <grundler@parisc-linux.org>
To: Tony Camuso <tcamuso@redhat.com>
Cc: Arjan van de Ven <arjan@infradead.org>,
Yinghai Lu <yhlu.kernel@gmail.com>,
Matthew Wilcox <matthew@wil.cx>, Greg KH <greg@kroah.com>,
Grant Grundler <grundler@parisc-linux.org>,
Loic Prylli <loic@myri.com>, Adrian Bunk <bunk@kernel.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
Ivan Kokshaysky <ink@jurassic.park.msu.ru>,
Greg KH <gregkh@suse.de>,
linux-kernel@vger.kernel.org, Jeff Garzik <jeff@garzik.org>,
linux-pci@atrey.karlin.mff.cuni.cz, Martin Mares <mj@ucw.cz>
Subject: Re: [PATCH] Change pci_raw_ops to pci_raw_read/write
Date: Thu, 7 Feb 2008 19:28:54 -0700 [thread overview]
Message-ID: <20080208022854.GF28163@colo.lackof.org> (raw)
In-Reply-To: <47AB3382.3030806@redhat.com>
On Thu, Feb 07, 2008 at 11:36:18AM -0500, Tony Camuso wrote:
> Arjan van de Ven wrote:
>> On Thu, 07 Feb 2008 10:54:05 -0500
>> Tony Camuso <tcamuso@redhat.com> wrote:
>>> Matthew,
>>>
>>> Perhaps I missed it, but did you address Yinghai's concerns?
>>>
>>> Yinghai Lu wrote:
>>>> On Jan 28, 2008 7:03 PM, Matthew Wilcox <matthew@wil.cx> wrote:
>>>>> -int pci_conf1_write(unsigned int seg, unsigned int bus,
>>>>> +static int pci_conf1_write(unsigned int seg, unsigned int bus,
>>>>> unsigned int devfn, int reg, int len,
>>>>> u32 value)
>>>> any reason to change pci_conf1_read/write to static?
>>>>
>> nothing should use these directly. So static is the right answer ;)
>
> Agreed. Thanks, Arjan.
>
> Matthew,
> What about the ATA_RAM addition to Kconfig? Was it accidental,
> or intended? If intended, how is it related?
AFAICT, it looks accidental. I can't see how it's related.
He should be back online next week and can answer for himself.
hth,
grant
next prev parent reply other threads:[~2008-02-08 2:29 UTC|newest]
Thread overview: 125+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-12-25 11:26 [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in Arjan van de Ven
2007-12-27 11:52 ` Jeff Garzik
2007-12-27 14:09 ` Arjan van de Ven
2007-12-27 17:52 ` Linus Torvalds
2008-01-11 19:02 ` Greg KH
2008-01-11 19:09 ` Arjan van de Ven
2008-01-11 19:14 ` Greg KH
2008-01-11 19:28 ` Matthew Wilcox
2008-01-11 19:40 ` Arjan van de Ven
2008-01-11 19:45 ` Greg KH
2008-01-11 19:49 ` Matthew Wilcox
2008-01-11 19:58 ` Linus Torvalds
2008-01-11 20:17 ` Matthew Wilcox
2008-01-11 20:27 ` Linus Torvalds
2008-01-11 20:42 ` Matthew Wilcox
2008-01-11 21:12 ` Linus Torvalds
2008-01-11 21:17 ` Matthew Wilcox
2008-01-11 21:28 ` Linus Torvalds
2008-01-11 21:38 ` Matthew Wilcox
2008-01-11 23:58 ` Ivan Kokshaysky
2008-01-12 0:17 ` Jesse Barnes
2008-01-12 0:26 ` Greg KH
2008-01-12 14:40 ` Ivan Kokshaysky
2008-01-12 15:46 ` Arjan van de Ven
2008-01-12 16:23 ` Ivan Kokshaysky
2008-01-12 17:45 ` Arjan van de Ven
2008-01-12 18:17 ` Matthew Wilcox
2008-01-12 21:49 ` Ivan Kokshaysky
2008-01-12 23:01 ` Arjan van de Ven
2008-01-13 0:12 ` Tony Camuso
2008-01-13 0:40 ` Arjan van de Ven
2008-01-13 1:36 ` Tony Camuso
2008-01-13 4:42 ` Arjan van de Ven
2008-01-13 4:47 ` Matthew Wilcox
2008-01-13 6:43 ` Jeff Garzik
2008-01-13 12:43 ` Tony Camuso
2008-01-13 17:03 ` Arjan van de Ven
2008-01-13 21:28 ` Tony Camuso
2008-01-14 0:54 ` Alan Cox
2008-01-14 1:33 ` Arjan van de Ven
2008-01-14 3:29 ` Tony Camuso
2008-01-14 5:05 ` Arjan van de Ven
2008-01-14 13:01 ` Tony Camuso
2008-01-14 14:46 ` Arjan van de Ven
2008-01-14 15:23 ` Tony Camuso
2008-01-14 16:01 ` Arjan van de Ven
2008-01-14 16:08 ` Tony Camuso
2008-01-14 9:11 ` Alan Cox
2008-01-14 5:20 ` Linus Torvalds
2008-01-13 18:23 ` Loic Prylli
2008-01-13 18:41 ` Arjan van de Ven
2008-01-13 20:43 ` Matthew Wilcox
2008-01-13 21:18 ` Loic Prylli
2008-01-13 20:51 ` Loic Prylli
2008-01-13 7:08 ` Benjamin Herrenschmidt
2008-01-13 7:24 ` Matthew Wilcox
2008-01-13 7:58 ` Matthew Wilcox
2008-01-13 17:01 ` Arjan van de Ven
2008-01-14 22:52 ` Matthew Wilcox
2008-01-14 23:04 ` Adrian Bunk
2008-01-15 16:00 ` Loic Prylli
2008-01-15 17:46 ` Greg KH
2008-01-15 17:56 ` Matthew Wilcox
2008-01-15 19:27 ` Tony Camuso
2008-01-15 19:38 ` Linus Torvalds
2008-01-15 19:40 ` Matthew Wilcox
2008-01-15 22:12 ` Loic Prylli
2008-01-19 16:58 ` Grant Grundler
2008-01-28 18:32 ` Tony Camuso
2008-01-28 20:44 ` Greg KH
2008-01-28 22:31 ` Matthew Wilcox
2008-01-28 22:53 ` Greg KH
2008-01-29 2:56 ` Matthew Wilcox
2008-01-29 2:57 ` PCI x86: always use conf1 to access config space below 256 bytes Matthew Wilcox
2008-01-29 13:21 ` Greg KH
2008-01-29 23:43 ` Matthew Wilcox
2008-01-30 0:04 ` Linus Torvalds
2008-01-29 3:03 ` [PATCH] Change pci_raw_ops to pci_raw_read/write Matthew Wilcox
2008-02-03 7:30 ` Yinghai Lu
2008-02-07 15:54 ` Tony Camuso
2008-02-07 16:28 ` Arjan van de Ven
2008-02-07 16:36 ` Tony Camuso
2008-02-08 2:28 ` Grant Grundler [this message]
2008-02-09 12:41 ` Matthew Wilcox
2008-02-10 6:25 ` Yinghai Lu
2008-02-10 7:21 ` Greg KH
2008-02-10 14:51 ` Matthew Wilcox
2008-02-10 19:13 ` Grant Grundler
2008-02-10 19:37 ` Matthew Wilcox
2008-02-10 20:16 ` Yinghai Lu
2008-02-10 20:19 ` Matthew Wilcox
2008-02-10 20:25 ` Yinghai Lu
2008-02-10 20:32 ` Matthew Wilcox
2008-02-10 20:47 ` Yinghai Lu
2008-02-10 20:24 ` Linus Torvalds
2008-02-10 20:45 ` Matthew Wilcox
2008-02-10 23:02 ` raw_pci_read in quirk_intel_irqbalance Matthew Wilcox
2008-02-11 5:04 ` Matthew Wilcox
2008-02-11 7:49 ` Grant Grundler
2008-02-11 16:15 ` Matthew Wilcox
2008-02-11 17:18 ` Linus Torvalds
2008-02-11 19:38 ` Grant Grundler
2008-02-11 1:49 ` [PATCH] Change pci_raw_ops to pci_raw_read/write Yinghai Lu
2008-02-11 2:53 ` Robert Hancock
2008-02-11 5:59 ` Yinghai Lu
2008-02-11 22:10 ` Andrew Morton
2008-02-11 22:38 ` Ingo Molnar
2008-01-29 3:05 ` [Patch v2] Make PCI extended config space (MMCONFIG) a driver opt-in Arjan van de Ven
2008-01-29 3:18 ` Matthew Wilcox
2008-01-29 13:19 ` Greg KH
2008-01-29 14:15 ` Tony Camuso
2008-01-29 14:47 ` Arjan van de Ven
2008-01-29 15:15 ` Tony Camuso
2008-01-29 15:29 ` Arjan van de Ven
2008-01-29 16:26 ` Tony Camuso
2008-01-29 23:57 ` Matthew Wilcox
2008-01-30 2:30 ` Tony Camuso
2008-01-30 3:45 ` Matthew Wilcox
2008-01-30 15:15 ` Ivan Kokshaysky
2008-01-30 15:42 ` Arjan van de Ven
2008-01-30 20:14 ` Ivan Kokshaysky
2008-01-31 5:51 ` Jesse Barnes
2008-01-11 19:54 ` Arjan van de Ven
2008-01-11 20:55 ` Greg KH
2008-01-15 12:58 ` Øyvind Vågen Jægtnes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080208022854.GF28163@colo.lackof.org \
--to=grundler@parisc-linux.org \
--cc=arjan@infradead.org \
--cc=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=greg@kroah.com \
--cc=gregkh@suse.de \
--cc=ink@jurassic.park.msu.ru \
--cc=jeff@garzik.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@atrey.karlin.mff.cuni.cz \
--cc=loic@myri.com \
--cc=matthew@wil.cx \
--cc=mj@ucw.cz \
--cc=tcamuso@redhat.com \
--cc=torvalds@linux-foundation.org \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome