From: Ingo Molnar <mingo@elte.hu>
To: Sam Ravnborg <sam@ravnborg.org>
Cc: linux-kernel@vger.kernel.org,
Linus Torvalds <torvalds@linux-foundation.org>,
Andrew Morton <akpm@zip.com.au>,
Thomas Gleixner <tglx@linutronix.de>,
Jason Wessel <jason.wessel@windriver.com>
Subject: Re: [3/6] kgdb: core
Date: Sun, 10 Feb 2008 08:59:23 +0100 [thread overview]
Message-ID: <20080210075923.GB7188@elte.hu> (raw)
In-Reply-To: <20080210073153.GA9805@uranus.ravnborg.org>
* Sam Ravnborg <sam@ravnborg.org> wrote:
> I see that only a very few of my comments posted yesterday got
> addressed. On purpose or did you miss them?
no, they went into another thread :-)
i've now read your mail and addressed the majority of them - see the
details below.
i've trickled all these fixes back to keep a clean split, test-built and
test-booted the result, and updated the kgdb.git tree, which can be
pulled from:
git://git.kernel.org/pub/scm/linux/kernel/git/mingo/linux-2.6-kgdb.git
updated shortlog further below. I've re-tested kgdb on x86 and it still
works (as expected).
> > +struct debuggerinfo_struct {
> > + void *debuggerinfo;
> > + struct task_struct *task;
> > +} kgdb_info[NR_CPUS];
> static?
fixed.
> > +
> > +/* Is a host GDB connected to us? */
> > +int kgdb_connected;
> > +EXPORT_SYMBOL_GPL(kgdb_connected);
> Drop additional spaces.
> Add kernel-doc comments explaining the usage.
if you look at the resulting kernel/kgdb.c not the patch itself then
you'll see that this is consistent style that aligns this variable with
other fields. I agree that it looks ugly in isolation in the quote
above.
> > +/* All the KGDB handlers are installed */
> > +int kgdb_io_module_registered;
> static? drop spaces.
static: fixed. Spaces: see above.
> > +/* Guard for recursive entry */
> > +static int exception_level;
> drop spaces. In more places below - but they are obvious.
really, please look at the resulting kernel/kgdb.c file. It's visually
consistent.
> > +struct kgdb_bkpt kgdb_break[KGDB_MAX_BREAKPOINTS] = {
> > + [0 ... KGDB_MAX_BREAKPOINTS-1] = { .state = BP_UNDEFINED }
> > +};
> static?
fixed.
> > +
> > +extern int pid_max;
>
> extern must be moved to a .h file.
i did that in my series.
> > +atomic_t kgdb_setting_breakpoint;
> static?
fixed.
> Many more variables are static candidates. I will not repeat it.
i think i fixed all of them.
> > +#ifdef __BIG_ENDIAN
> > + *buf++ = hexchars[(tmp_s >> 12) & 0xf];
> > + *buf++ = hexchars[(tmp_s >> 8) & 0xf];
> > + *buf++ = hexchars[(tmp_s >> 4) & 0xf];
> > + *buf++ = hexchars[tmp_s & 0xf];
> > +#else
> > + *buf++ = hexchars[(tmp_s >> 4) & 0xf];
> > + *buf++ = hexchars[tmp_s & 0xf];
> > + *buf++ = hexchars[(tmp_s >> 12) & 0xf];
> > + *buf++ = hexchars[(tmp_s >> 8) & 0xf];
> > +#endif
> small helper function?
this is already part of a small helper function. (kgdb_mem2hex())
> > +int kgdb_isremovedbreak(unsigned long addr)
> > +{
> > + int i;
> > +
> > + for (i = 0; i < KGDB_MAX_BREAKPOINTS; i++) {
> > + if ((kgdb_break[i].state == BP_REMOVED) &&
> > + (kgdb_break[i].bpt_addr == addr))
> > + return 1;
> > + }
> > + return 0;
> > +}
> static?
no, needed by architectures.
> > +int remove_all_break(void)
> static?
no.
> > +int kgdb_io_ready(int print_wait)
> static?
yes, fixed.
> > + bool "KGDB: kernel debugging with remote gdb"
> > + select KGDB_ARCH_HAS_SHADOW_INFO if X86_64
> > + select DEBUG_INFO
> > + select FRAME_POINTER
> > + depends on DEBUG_KERNEL && ADD_A_KGDB_ARCH
>
> Replace ADD_A_...
> with
> HAVE_KGDB
fixed.
Ingo
------------------>
Ingo Molnar (3):
pids: add pid_max prototype
uaccess: add probe_kernel_write()
x86: kgdb support
Jan Kiszka (1):
consoles: polling support, kgdboc
Jason Wessel (2):
kgdb: core
kgdb: document parameters
Documentation/kernel-parameters.txt | 5 +
arch/x86/Kconfig | 4 +
arch/x86/kernel/Makefile | 1 +
arch/x86/kernel/kgdb.c | 550 ++++++++++
drivers/char/tty_io.c | 47 +
drivers/serial/8250.c | 62 ++
drivers/serial/Kconfig | 3 +
drivers/serial/Makefile | 1 +
drivers/serial/kgdboc.c | 164 +++
drivers/serial/serial_core.c | 67 ++-
include/asm-generic/kgdb.h | 93 ++
include/asm-x86/kgdb.h | 87 ++
include/linux/kgdb.h | 264 +++++
include/linux/pid.h | 2 +
include/linux/serial_core.h | 4 +
include/linux/tty_driver.h | 12 +
include/linux/uaccess.h | 22 +
kernel/Makefile | 1 +
kernel/kgdb.c | 2020 +++++++++++++++++++++++++++++++++++
kernel/sysctl.c | 2 +-
lib/Kconfig.debug | 2 +
lib/Kconfig.kgdb | 37 +
22 files changed, 3448 insertions(+), 2 deletions(-)
create mode 100644 arch/x86/kernel/kgdb.c
create mode 100644 drivers/serial/kgdboc.c
create mode 100644 include/asm-generic/kgdb.h
create mode 100644 include/asm-x86/kgdb.h
create mode 100644 include/linux/kgdb.h
create mode 100644 kernel/kgdb.c
create mode 100644 lib/Kconfig.kgdb
next prev parent reply other threads:[~2008-02-10 8:00 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-10 7:13 Ingo Molnar
2008-02-10 7:31 ` Sam Ravnborg
2008-02-10 7:59 ` Ingo Molnar [this message]
2008-02-10 7:35 ` Christoph Hellwig
2008-02-10 7:43 ` Ingo Molnar
2008-02-10 7:57 ` Christoph Hellwig
2008-02-10 8:02 ` Ingo Molnar
2008-02-10 8:21 ` Ingo Molnar
2008-02-10 8:26 ` Christoph Hellwig
2008-02-10 9:08 ` Ingo Molnar
2008-02-10 9:17 ` Ingo Molnar
2008-02-10 9:20 ` Ingo Molnar
2008-02-10 9:34 ` Ingo Molnar
2008-02-10 9:31 ` Christoph Hellwig
2008-02-10 17:17 ` [patch] kgdb light, v6 Ingo Molnar
2008-02-10 19:43 ` Bartlomiej Zolnierkiewicz
2008-02-10 21:31 ` Ingo Molnar
2008-02-10 20:55 ` Bartlomiej Zolnierkiewicz
2008-02-10 21:09 ` Ingo Molnar
2008-02-10 21:45 ` Jan Kiszka
2008-02-10 22:14 ` Bartlomiej Zolnierkiewicz
2008-02-10 22:32 ` Jan Kiszka
2008-02-10 22:40 ` Ingo Molnar
2008-02-11 2:35 ` Yinghai Lu
2008-02-10 22:31 ` Ingo Molnar
2008-02-10 22:24 ` Bartlomiej Zolnierkiewicz
2008-02-10 8:24 ` [3/6] kgdb: core Christoph Hellwig
2008-02-10 8:57 ` Ingo Molnar
2008-02-10 9:11 ` Christoph Hellwig
2008-02-10 9:27 ` Ingo Molnar
2008-02-10 9:34 ` Christoph Hellwig
2008-02-10 17:02 ` Ingo Molnar
2008-02-10 12:46 ` Marcin Slusarz
2008-02-10 13:19 ` Jesper Juhl
2008-02-10 14:00 ` Marcin Slusarz
2008-02-10 13:36 ` Jan Kiszka
2008-02-10 16:43 ` Ingo Molnar
2008-02-10 19:20 ` Bartlomiej Zolnierkiewicz
2008-02-10 16:46 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080210075923.GB7188@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@zip.com.au \
--cc=jason.wessel@windriver.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®