Re: [3/6] kgdb: core

[Christoph Hellwig <hch@infradead.org>]

On Sun, Feb 10, 2008 at 09:57:35AM +0100, Ingo Molnar wrote:
> > It would be nice if you could move the kerneldoc comments to the 
> > proper place at least. [...]
> 
> i'd agree in general but this is really a special case, please look at 
> the context. This would duplicate all the kerneldoc headers for all 
> architectures. We'd have to move the same kerneldoc header to all 
> architecture arch/*/kernel/kgdb.c files. It's much nicer in 
> asm-generic/kgdb.h.

Well, the point of kerneldoc comments is that they're reasily
extractable.  If you want to document the arch interface a pure
text document in Documentation/ might be a better choice.

> > Also it seems at least some of Jan's patches are missing aswell.
> 
> i dont think so. Which ones do you mean? I just reviewed them and they 
> are either already done, or moot (for kgdb complications that i objected 
> to and removed from this kgdb-x86 tree).

The one I noticed quickly is the __ASSEMBLY__ removal from
asm-x86/kgdb.h.  I haven't looked at the serial bits because I don't
think I'm qualified to comment on those, but I'm also not seeing any
replies to any of his patches.  Especially the comments on the arch
interface seem like something that should be acted upon to me.