* [2.6 patch] x86: make mxcsr_feature_mask static again
@ 2008-02-13 21:29 Adrian Bunk
2008-02-13 21:38 ` Roland McGrath
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Adrian Bunk @ 2008-02-13 21:29 UTC (permalink / raw)
To: Roland McGrath, tglx, mingo, hpa; +Cc: linux-kernel
mxcsr_feature_mask needlessly became global.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
arch/x86/kernel/i387.c | 2 +-
include/asm-x86/i387.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
76adc866d04ed20a5b2eb548920f93ad87268cbd
diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c
index 26719bd..763dfc4 100644
--- a/arch/x86/kernel/i387.c
+++ b/arch/x86/kernel/i387.c
@@ -39,7 +39,7 @@
#define HAVE_HWFP 1
#endif
-unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
+static unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
void mxcsr_feature_mask_init(void)
{
diff --git a/include/asm-x86/i387.h b/include/asm-x86/i387.h
index ba8105c..4c7706a 100644
--- a/include/asm-x86/i387.h
+++ b/include/asm-x86/i387.h
@@ -19,7 +19,6 @@
#include <asm/uaccess.h>
extern void fpu_init(void);
-extern unsigned int mxcsr_feature_mask;
extern void mxcsr_feature_mask_init(void);
extern void init_fpu(struct task_struct *child);
extern asmlinkage void math_state_restore(void);
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [2.6 patch] x86: make mxcsr_feature_mask static again
2008-02-13 21:29 [2.6 patch] x86: make mxcsr_feature_mask static again Adrian Bunk
@ 2008-02-13 21:38 ` Roland McGrath
2008-02-16 18:22 ` Thomas Gleixner
2008-02-17 13:55 ` Thomas Gleixner
2 siblings, 0 replies; 4+ messages in thread
From: Roland McGrath @ 2008-02-13 21:38 UTC (permalink / raw)
To: Adrian Bunk; +Cc: tglx, mingo, hpa, linux-kernel
Good change. Making it global was needed temporarily in between some of
the i387 unification patches, but is unnecessary after the final merge.
Thanks,
Roland
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] x86: make mxcsr_feature_mask static again
2008-02-13 21:29 [2.6 patch] x86: make mxcsr_feature_mask static again Adrian Bunk
2008-02-13 21:38 ` Roland McGrath
@ 2008-02-16 18:22 ` Thomas Gleixner
2008-02-17 13:55 ` Thomas Gleixner
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2008-02-16 18:22 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Roland McGrath, mingo, hpa, linux-kernel
On Wed, 13 Feb 2008, Adrian Bunk wrote:
> mxcsr_feature_mask needlessly became global.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied. Thanks,
tglx
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [2.6 patch] x86: make mxcsr_feature_mask static again
2008-02-13 21:29 [2.6 patch] x86: make mxcsr_feature_mask static again Adrian Bunk
2008-02-13 21:38 ` Roland McGrath
2008-02-16 18:22 ` Thomas Gleixner
@ 2008-02-17 13:55 ` Thomas Gleixner
2 siblings, 0 replies; 4+ messages in thread
From: Thomas Gleixner @ 2008-02-17 13:55 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Roland McGrath, mingo, hpa, linux-kernel
On Wed, 13 Feb 2008, Adrian Bunk wrote:
> mxcsr_feature_mask needlessly became global.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Applied along with the other x86 ones.
Thanks,
tglx
> ---
>
> arch/x86/kernel/i387.c | 2 +-
> include/asm-x86/i387.h | 1 -
> 2 files changed, 1 insertion(+), 2 deletions(-)
>
> 76adc866d04ed20a5b2eb548920f93ad87268cbd
> diff --git a/arch/x86/kernel/i387.c b/arch/x86/kernel/i387.c
> index 26719bd..763dfc4 100644
> --- a/arch/x86/kernel/i387.c
> +++ b/arch/x86/kernel/i387.c
> @@ -39,7 +39,7 @@
> #define HAVE_HWFP 1
> #endif
>
> -unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
> +static unsigned int mxcsr_feature_mask __read_mostly = 0xffffffffu;
>
> void mxcsr_feature_mask_init(void)
> {
> diff --git a/include/asm-x86/i387.h b/include/asm-x86/i387.h
> index ba8105c..4c7706a 100644
> --- a/include/asm-x86/i387.h
> +++ b/include/asm-x86/i387.h
> @@ -19,7 +19,6 @@
> #include <asm/uaccess.h>
>
> extern void fpu_init(void);
> -extern unsigned int mxcsr_feature_mask;
> extern void mxcsr_feature_mask_init(void);
> extern void init_fpu(struct task_struct *child);
> extern asmlinkage void math_state_restore(void);
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-02-17 13:56 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-13 21:29 [2.6 patch] x86: make mxcsr_feature_mask static again Adrian Bunk
2008-02-13 21:38 ` Roland McGrath
2008-02-16 18:22 ` Thomas Gleixner
2008-02-17 13:55 ` Thomas Gleixner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®