From: Adrian Bunk <bunk@kernel.org>
To: Jan Engelhardt <jengelh@computergmbh.de>
Cc: "Ed L. Cashin" <ecashin@coraid.com>, linux-kernel@vger.kernel.org
Subject: Re: [2.6 patch] #if 0 aoedev_isbusy()
Date: Thu, 14 Feb 2008 00:05:37 +0200 [thread overview]
Message-ID: <20080213220537.GA24319@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <Pine.LNX.4.64.0802132303150.29154@fbirervta.pbzchgretzou.qr>
On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
>
> On Feb 13 2008 23:30, Adrian Bunk wrote:
> >
> >This patch #if 0's the no longer used aoedev_isbusy().
>
> Why not just remove it? (It can be resurrected from earlier
> revisions should it be needed again.)
I've switched to doing #if 0 instead since this addresses the
"It might be needed in the future." answer I otherwise sometimes
got.
But if a maintainer wants to have such a function deleted instead that's
fine with me.
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-02-13 22:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-13 21:30 Adrian Bunk
2008-02-13 22:03 ` Jan Engelhardt
2008-02-13 22:05 ` Adrian Bunk [this message]
2008-02-13 22:56 ` Ed L. Cashin
2008-02-14 21:23 ` [2.6 patch] remove aoedev_isbusy() Adrian Bunk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080213220537.GA24319@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=ecashin@coraid.com \
--cc=jengelh@computergmbh.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®