mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: "Ed L. Cashin" <ecashin@coraid.com>
Cc: Jan Engelhardt <jengelh@computergmbh.de>, linux-kernel@vger.kernel.org
Subject: [2.6 patch] remove aoedev_isbusy()
Date: Thu, 14 Feb 2008 23:23:57 +0200	[thread overview]
Message-ID: <20080214212357.GE23227@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <20080213225653.GK4355@coraid.com>

On Wed, Feb 13, 2008 at 05:56:53PM -0500, Ed L. Cashin wrote:
> On Thu, Feb 14, 2008 at 12:05:37AM +0200, Adrian Bunk wrote:
> > On Wed, Feb 13, 2008 at 11:03:35PM +0100, Jan Engelhardt wrote:
> > > 
> > > On Feb 13 2008 23:30, Adrian Bunk wrote:
> > > >
> > > >This patch #if 0's the no longer used aoedev_isbusy().
> > > 
> > > Why not just remove it? (It can be resurrected from earlier
> > > revisions should it be needed again.)
> > 
> > I've switched to doing #if 0 instead since this addresses the
> > "It might be needed in the future." answer I otherwise sometimes
> > got.
> > 
> > But if a maintainer wants to have such a function deleted instead that's 
> > fine with me.
> 
> Hello.  That function can go away.  I have some changes pending, but
> none of them use aoedev_isbusy.  Thanks for Cc-ing me.

Updated patch below

cu
Adrian


<--  snip  -->


This patch removes the no longer used aoedev_isbusy().

Signed-off-by: Adrian Bunk <bunk@kernel.org>

---

 drivers/block/aoe/aoe.h    |    1 -
 drivers/block/aoe/aoedev.c |   18 ------------------
 2 files changed, 19 deletions(-)

13d7ce5f6fa02341f1642f684847ce409bbd5b1d diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 280e71e..5b4c6e6 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -195,7 +195,6 @@ void aoedev_exit(void);
 struct aoedev *aoedev_by_aoeaddr(int maj, int min);
 struct aoedev *aoedev_by_sysminor_m(ulong sysminor);
 void aoedev_downdev(struct aoedev *d);
-int aoedev_isbusy(struct aoedev *d);
 int aoedev_flush(const char __user *str, size_t size);
 
 int aoenet_init(void);
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index f9a1cd9..a1d813a 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/drivers/block/aoe/aoedev.c
@@ -18,24 +18,6 @@ static void skbpoolfree(struct aoedev *d);
 static struct aoedev *devlist;
 static DEFINE_SPINLOCK(devlist_lock);
 
-int
-aoedev_isbusy(struct aoedev *d)
-{
-	struct aoetgt **t, **te;
-	struct frame *f, *e;
-
-	t = d->targets;
-	te = t + NTARGETS;
-	for (; t < te && *t; t++) {
-		f = (*t)->frames;
-		e = f + (*t)->nframes;
-		for (; f < e; f++)
-			if (f->tag != FREETAG)
-				return 1;
-	}
-	return 0;
-}
-
 struct aoedev *
 aoedev_by_aoeaddr(int maj, int min)
 {


      reply	other threads:[~2008-02-14 21:24 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-13 21:30 [2.6 patch] #if 0 aoedev_isbusy() Adrian Bunk
2008-02-13 22:03 ` Jan Engelhardt
2008-02-13 22:05   ` Adrian Bunk
2008-02-13 22:56     ` Ed L. Cashin
2008-02-14 21:23       ` Adrian Bunk [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080214212357.GE23227@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=ecashin@coraid.com \
    --cc=jengelh@computergmbh.de \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®