mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 2/4] IPMI: Remove unnecessary memory barriers
@ 2008-02-14 18:28 Corey Minyard
  0 siblings, 0 replies; only message in thread
From: Corey Minyard @ 2008-02-14 18:28 UTC (permalink / raw)
  To: Linux Kernel; +Cc: Andrew Morton, OpenIPMI Developers

From: Corey Minyard <cminyard@mvista.com>

Remove some unnecessary barriers.

Signed-off-by: Corey Minyard <cminyard@mvista.com>
---
This can be folded into ipmi-dont-grab-locks-in-run-to-completion-mode.patch

Index: linux-2.6.24/drivers/char/ipmi/ipmi_msghandler.c
===================================================================
--- linux-2.6.24.orig/drivers/char/ipmi/ipmi_msghandler.c
+++ linux-2.6.24/drivers/char/ipmi/ipmi_msghandler.c
@@ -3518,7 +3518,6 @@ void ipmi_smi_msg_received(ipmi_smi_t   
 	/* To preserve message order, if the list is not empty, we
            tack this message onto the end of the list. */
 	run_to_completion = intf->run_to_completion;
-	barrier();
 	if (!run_to_completion)
 		spin_lock_irqsave(&intf->waiting_msgs_lock, flags);
 	if (!list_empty(&intf->waiting_msgs)) {
@@ -3535,7 +3534,6 @@ void ipmi_smi_msg_received(ipmi_smi_t   
 		/* Could not handle the message now, just add it to a
                    list to handle later. */
 		run_to_completion = intf->run_to_completion;
-		barrier();
 		if (!run_to_completion)
 			spin_lock_irqsave(&intf->waiting_msgs_lock, flags);
 		list_add_tail(&msg->link, &intf->waiting_msgs);

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2008-02-14 18:38 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-14 18:28 [PATCH 2/4] IPMI: Remove unnecessary memory barriers Corey Minyard

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®