From: Oleg Nesterov <oleg@tv-sign.ru>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Roland McGrath <roland@redhat.com>, linux-kernel@vger.kernel.org
Subject: [PATCH] do_signal_stop: use signal_group_exit()
Date: Fri, 15 Feb 2008 21:02:04 +0300 [thread overview]
Message-ID: <20080215180204.GA4359@tv-sign.ru> (raw)
do_signal_stop() needs signal_group_exit() but checks sig->group_exit_task.
This (optimization) is correct, SIGNAL_STOP_DEQUEUED and SIGNAL_GROUP_EXIT
are mutually exclusive, but looks confusing. Use signal_group_exit(), this
is not fastpath, the code clarity is more important.
Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
--- 25/kernel/signal.c~6_DO_SIGNAL_STOP 2008-02-15 16:59:17.000000000 +0300
+++ 25/kernel/signal.c 2008-02-15 20:34:32.000000000 +0300
@@ -1718,7 +1718,7 @@ static int do_signal_stop(int signr)
struct task_struct *t;
if (!likely(sig->flags & SIGNAL_STOP_DEQUEUED) ||
- unlikely(sig->group_exit_task))
+ unlikely(signal_group_exit(sig)))
return 0;
/*
* There is no group stop already in progress.
next reply other threads:[~2008-02-15 17:58 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-15 18:02 Oleg Nesterov [this message]
2008-02-16 3:37 ` Andrew Morton
2008-02-16 14:02 ` Oleg Nesterov
2008-02-17 23:10 ` Oleg Nesterov
2008-02-18 4:11 ` Eric W. Biederman
2008-02-19 23:39 ` Valdis.Kletnieks
2008-02-20 16:14 ` [PATCH] (for -mm only) put_pid: make sure we don't free the live pid Oleg Nesterov
2008-02-20 16:18 ` tty && pid problems Oleg Nesterov
2008-02-20 16:19 ` Alan Cox
2008-02-22 1:39 ` Eric W. Biederman
2008-02-22 9:37 ` Alan Cox
2008-02-20 16:28 ` Oleg Nesterov
2008-02-20 19:00 ` Jiri Slaby
2008-02-20 2:32 ` [PATCH] do_signal_stop: use signal_group_exit() Eric W. Biederman
2008-02-16 15:09 ` [PATCH] free_pidmap: turn it into free_pidmap(struct upid *) Oleg Nesterov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080215180204.GA4359@tv-sign.ru \
--to=oleg@tv-sign.ru \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®