mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: ebiederm@xmission.com (Eric W. Biederman)
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Oleg Nesterov <oleg@tv-sign.ru>,
	Valdis.Kletnieks@vt.edu,
	Andrew Morton <akpm@linux-foundation.org>,
	roland@redhat.com, linux-kernel@vger.kernel.org,
	Pavel Emelyanov <xemul@openvz.org>,
	Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>
Subject: Re: tty && pid problems
Date: Thu, 21 Feb 2008 18:39:21 -0700	[thread overview]
Message-ID: <m1ejb56a7q.fsf@ebiederm.dsl.xmission.com> (raw)
In-Reply-To: <20080220161941.6e9a2e16@core> (Alan Cox's message of "Wed, 20 Feb 2008 16:19:41 +0000")

Alan Cox <alan@lxorguk.ukuu.org.uk> writes:

>> > *ping* - Any further activity on this one?  I got bit by it as well on
>> > the very first attempted boot of 25-rc2-mm1, the instant it tried to leave
>> > single-user and go multi-user.
>> 
>> Valdis, any chance you can try the
>> 	"[PATCH] (for -mm only) put_pid: make sure we don't free the live pid"
>> I sent? just to make sure we don't have other problems here.
>
> There is some other iffy locking of the pid objects ever since they were
> changed from pid_t to ref counted structs. Whoever did that didn't add
> any locking for it, and the old code knew it was "safe" not to.
>
> I've added locks in my test tree and now I've finally got -mm to build
> will do some testing then push more stuff upstream

Thanks.  At the tty layer that was probably me.
Most of the instances already appear to be nested in some other kind of
locking, but that doesn't make no additional locking correct or ensure
that it will give a uniform result.

Eric


  reply	other threads:[~2008-02-22  1:42 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-15 18:02 [PATCH] do_signal_stop: use signal_group_exit() Oleg Nesterov
2008-02-16  3:37 ` Andrew Morton
2008-02-16 14:02   ` Oleg Nesterov
2008-02-17 23:10     ` Oleg Nesterov
2008-02-18  4:11       ` Eric W. Biederman
2008-02-19 23:39         ` Valdis.Kletnieks
2008-02-20 16:14           ` [PATCH] (for -mm only) put_pid: make sure we don't free the live pid Oleg Nesterov
2008-02-20 16:18           ` tty && pid problems Oleg Nesterov
2008-02-20 16:19             ` Alan Cox
2008-02-22  1:39               ` Eric W. Biederman [this message]
2008-02-22  9:37                 ` Alan Cox
2008-02-20 16:28             ` Oleg Nesterov
2008-02-20 19:00               ` Jiri Slaby
2008-02-20  2:32       ` [PATCH] do_signal_stop: use signal_group_exit() Eric W. Biederman
2008-02-16 15:09   ` [PATCH] free_pidmap: turn it into free_pidmap(struct upid *) Oleg Nesterov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=m1ejb56a7q.fsf@ebiederm.dsl.xmission.com \
    --to=ebiederm@xmission.com \
    --cc=Valdis.Kletnieks@vt.edu \
    --cc=akpm@linux-foundation.org \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=oleg@tv-sign.ru \
    --cc=roland@redhat.com \
    --cc=xemul@openvz.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome