mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c
@ 2008-02-17 13:41 Paolo Ciarrocchi
  2008-02-17 15:05 ` Alexey Dobriyan
  2008-02-17 15:45 ` Ingo Molnar
  0 siblings, 2 replies; 3+ messages in thread
From: Paolo Ciarrocchi @ 2008-02-17 13:41 UTC (permalink / raw)
  To: Ingo Molnar, Linux Kernel

[PATCH] x86: coding style fixes in arch/x86/lib/io_64.c

This simple patch makes the file error free (according to
checkpatch.pl)


Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
---
 arch/x86/lib/io_64.c |   10 +++++-----
 1 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/x86/lib/io_64.c b/arch/x86/lib/io_64.c
index 87b4a4e..71fdf4b 100644
--- a/arch/x86/lib/io_64.c
+++ b/arch/x86/lib/io_64.c
@@ -2,15 +2,15 @@
 #include <asm/io.h>
 #include <linux/module.h>
 
-void __memcpy_toio(unsigned long dst,const void*src,unsigned len)
+void __memcpy_toio(unsigned long dst, const void*src, unsigned len)
 {
-	__inline_memcpy((void *) dst,src,len);
+	__inline_memcpy((void *) dst, src, len);
 }
 EXPORT_SYMBOL(__memcpy_toio);
 
-void __memcpy_fromio(void *dst,unsigned long src,unsigned len)
+void __memcpy_fromio(void *dst, unsigned long src, unsigned len)
 {
-	__inline_memcpy(dst,(const void *) src,len);
+	__inline_memcpy(dst, (const void *) src, len);
 }
 EXPORT_SYMBOL(__memcpy_fromio);
 
@@ -18,6 +18,6 @@ void memset_io(volatile void __iomem *a, int b, size_t c)
 {
 	/* XXX: memset can mangle the IO patterns quite a bit.
 	   perhaps it would be better to use a dumb one */
-	memset((void *)a,b,c);
+	memset((void *)a, b, c);
 }
 EXPORT_SYMBOL(memset_io);
-- 
1.5.4.1.183.gf873


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c
  2008-02-17 13:41 [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c Paolo Ciarrocchi
@ 2008-02-17 15:05 ` Alexey Dobriyan
  2008-02-17 15:45 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2008-02-17 15:05 UTC (permalink / raw)
  To: Paolo Ciarrocchi; +Cc: Ingo Molnar, Linux Kernel

On Sun, Feb 17, 2008 at 02:41:16PM +0100, Paolo Ciarrocchi wrote:
> [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c
> 
> This simple patch makes the file error free (according to
> checkpatch.pl)
> 
> 
> Signed-off-by: Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com>
> ---
>  arch/x86/lib/io_64.c |   10 +++++-----
>  1 files changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/x86/lib/io_64.c b/arch/x86/lib/io_64.c
> index 87b4a4e..71fdf4b 100644
> --- a/arch/x86/lib/io_64.c
> +++ b/arch/x86/lib/io_64.c
> @@ -2,15 +2,15 @@
>  #include <asm/io.h>
>  #include <linux/module.h>
>  
> -void __memcpy_toio(unsigned long dst,const void*src,unsigned len)
> +void __memcpy_toio(unsigned long dst, const void*src, unsigned len)
                                               ^^^^^^^^
Please, fix all coding style violations so that nobody will do this in
next 5 years or so.

^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c
  2008-02-17 13:41 [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c Paolo Ciarrocchi
  2008-02-17 15:05 ` Alexey Dobriyan
@ 2008-02-17 15:45 ` Ingo Molnar
  1 sibling, 0 replies; 3+ messages in thread
From: Ingo Molnar @ 2008-02-17 15:45 UTC (permalink / raw)
  To: Paolo Ciarrocchi; +Cc: Linux Kernel, Thomas Gleixner


* Paolo Ciarrocchi <paolo.ciarrocchi@gmail.com> wrote:

> [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c
> 
> This simple patch makes the file error free (according to 
> checkpatch.pl)

thanks, applied. (i fixed the other minor style problems in this file 
too, so that we have it all in a single patch)

	Ingo

^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2008-02-17 15:45 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-17 13:41 [PATCH] x86: coding style fixes in arch/x86/lib/io_64.c Paolo Ciarrocchi
2008-02-17 15:05 ` Alexey Dobriyan
2008-02-17 15:45 ` Ingo Molnar

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®