* [PATCH] modpost: Fix reversed symbol name order
@ 2008-02-17 13:12 Geert Uytterhoeven
2008-02-17 19:31 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2008-02-17 13:12 UTC (permalink / raw)
To: Sam Ravnborg; +Cc: linux-kbuild, Linux Kernel Development
XXXINIT_TO_INIT and XXXEXIT_TO_EXIT warnings use the reversed symbol name order
in the suggestion, e.g.:
WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference from the function free_area_init_core() to the function .init.text:setup_usemap()
The function __meminit free_area_init_core() references
a function __init setup_usemap().
If free_area_init_core is only used by setup_usemap then
annotate free_area_init_core with a matching annotation.
Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>
---
scripts/mod/modpost.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/scripts/mod/modpost.c
+++ b/scripts/mod/modpost.c
@@ -1200,7 +1200,7 @@ static void report_sec_mismatch(const ch
"annotate %s with a matching annotation.\n",
from, sec2annotation(fromsec), fromsym, from_p,
to, sec2annotation(tosec), tosym, to_p,
- fromsym, tosym, fromsym);
+ tosym, fromsym, tosym);
break;
case INIT_TO_EXIT:
fprintf(stderr,
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] modpost: Fix reversed symbol name order
2008-02-17 13:12 [PATCH] modpost: Fix reversed symbol name order Geert Uytterhoeven
@ 2008-02-17 19:31 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2008-02-17 19:31 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: linux-kbuild, Linux Kernel Development
On Sun, Feb 17, 2008 at 02:12:10PM +0100, Geert Uytterhoeven wrote:
> XXXINIT_TO_INIT and XXXEXIT_TO_EXIT warnings use the reversed symbol name order
> in the suggestion, e.g.:
>
> WARNING: vmlinux.o(.meminit.text+0x36c): Section mismatch in reference from the function free_area_init_core() to the function .init.text:setup_usemap()
> The function __meminit free_area_init_core() references
> a function __init setup_usemap().
> If free_area_init_core is only used by setup_usemap then
> annotate free_area_init_core with a matching annotation.
>
Ups - applied.
Thanks,
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-02-17 19:31 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-02-17 13:12 [PATCH] modpost: Fix reversed symbol name order Geert Uytterhoeven
2008-02-17 19:31 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®