mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Adrian Bunk <bunk@kernel.org>
To: Andrew Patterson <andrew.patterson@hp.com>,
	Greg Kroah-Hartman <gregkh@suse.de>
Cc: linux-kernel@vger.kernel.org, linux-pci@atrey.karlin.mff.cuni.cz
Subject: pci/pcie/aer/aerdrv_acpi.c: inconsequent NULL checking
Date: Tue, 19 Feb 2008 21:29:02 +0200	[thread overview]
Message-ID: <20080219192902.GD31955@cs181133002.pp.htv.fi> (raw)

The Coverity checker spotted the following inconsequent NULL checking 
introduced by commit 3c75e23784e6ed5f4841de43d0750fd9b37bafcb:

<--  snip  -->

...
int aer_osc_setup(struct pcie_device *pciedev)
{
...            vvvvvvvvv
        while (pdev->bus && pdev->bus->self)
                pdev = pdev->bus->self;
        handle = acpi_get_pci_rootbridge_handle(
                pci_domain_nr(pdev->bus), pdev->bus->number);
...                                       ^^^^^^^^^^^^^^^^^

<--  snip  -->

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed


             reply	other threads:[~2008-02-19 19:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-19 19:29 Adrian Bunk [this message]
2008-02-20  5:47 ` Greg KH
2008-02-20  7:56   ` Adrian Bunk
2008-02-20 16:09     ` Greg KH
2008-02-22 19:58       ` [2.6 patch] pci/pcie/aer/aerdrv_acpi.c: remove unneeded NULL check Adrian Bunk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080219192902.GD31955@cs181133002.pp.htv.fi \
    --to=bunk@kernel.org \
    --cc=andrew.patterson@hp.com \
    --cc=gregkh@suse.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®