From: Ingo Molnar <mingo@elte.hu>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Thomas Gleixner <tglx@linutronix.de>
Subject: Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu
Date: Tue, 26 Feb 2008 10:47:42 +0100 [thread overview]
Message-ID: <20080226094742.GM9857@elte.hu> (raw)
In-Reply-To: <47C3C0D1.1020304@zytor.com>
* H. Peter Anvin <hpa@zytor.com> wrote:
> Yinghai Lu wrote:
>>> which is the same. set_cpu_cap() is indeed the cleaner form to do this
>>> so your patch is correct as a cleanup.
>> set_cpu_cap is right
>> ==
>> set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong
>> should be
>> set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability);
>>
>> x86_capability is a array ...
>
> For an array, the & is optional and has no effect.
>
> So they mean the same thing.
yeah. It's unnecessary entropy nevertheless and i've cleaned it all up
in x86.git.
Ingo
next prev parent reply other threads:[~2008-02-26 9:48 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 7:20 Yinghai Lu
2008-02-26 7:14 ` Ingo Molnar
2008-02-26 7:20 ` Ingo Molnar
2008-02-26 7:24 ` Yinghai Lu
2008-02-26 7:33 ` H. Peter Anvin
2008-02-26 9:47 ` Ingo Molnar [this message]
2008-02-26 17:29 ` Yinghai Lu
2008-02-26 7:34 ` Ingo Molnar
2008-02-26 7:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080226094742.GM9857@elte.hu \
--to=mingo@elte.hu \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=yhlu.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®