From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Andrew Morton" <akpm@linux-foundation.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>,
"Thomas Gleixner" <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] x86_64: remove wrong setting about CONSTANT_TSC for intel cpu
Date: Mon, 25 Feb 2008 23:24:56 -0800 [thread overview]
Message-ID: <86802c440802252324u769f087fw83caa26c1960354e@mail.gmail.com> (raw)
In-Reply-To: <20080226072035.GB24820@elte.hu>
On Mon, Feb 25, 2008 at 11:20 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <Yinghai.Lu@Sun.COM> wrote:
>
>
> > also fix error in early_init_intel and reference about x86_capality,
> > because it is array already.., prevent possible data corruption...
>
> hm, why should there be data corruption:
>
>
> > - set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability);
> > + set_cpu_cap(c, X86_FEATURE_CONSTANT_TSC);
>
> cpu_cpu_cap() is currently defined as:
>
> #define set_cpu_cap(c, bit) set_bit(bit, (unsigned long *)((c)->x86_capability)
>
> which is the same. set_cpu_cap() is indeed the cleaner form to do this
> so your patch is correct as a cleanup.
set_cpu_cap is right
==
set_bit(X86_FEATURE_CONSTANT_TSC, &c->x86_capability); ===> is wrong
should be
set_bit(X86_FEATURE_CONSTANT_TSC, c->x86_capability);
x86_capability is a array ...
so this could prevent some data corruption.
YH
next prev parent reply other threads:[~2008-02-26 7:25 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-26 7:20 Yinghai Lu
2008-02-26 7:14 ` Ingo Molnar
2008-02-26 7:20 ` Ingo Molnar
2008-02-26 7:24 ` Yinghai Lu [this message]
2008-02-26 7:33 ` H. Peter Anvin
2008-02-26 9:47 ` Ingo Molnar
2008-02-26 17:29 ` Yinghai Lu
2008-02-26 7:34 ` Ingo Molnar
2008-02-26 7:39 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440802252324u769f087fw83caa26c1960354e@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®