From: Adrian Bunk <bunk@kernel.org>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>,
Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
Sam Ravnborg <sam@ravnborg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
Date: Wed, 27 Feb 2008 23:58:16 +0200 [thread overview]
Message-ID: <20080227215816.GX29269@cs181133002.pp.htv.fi> (raw)
In-Reply-To: <47C5D693.3030207@zytor.com>
On Wed, Feb 27, 2008 at 01:30:59PM -0800, H. Peter Anvin wrote:
> Adrian Bunk wrote:
>> On Wed, Feb 27, 2008 at 01:16:30PM -0800, Hiroshi Shimamoto wrote:
>>> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
>>>
>>> X86_HT is used for hyperthreading or multicore on 32-bit.
>>> The X86_HT on 64-bit is different from 32-bit, it means hyperthreading only.
>>> And X86_HT is not used on 64-bit except from cpu/initel_cacheinfo.c.
>>>
>>> Unify X86_HT for hyperthreading or multicore.
>>> Turn X86_HT on when X86_64 and SMP are enabled.
>>
>> Please fix it properly instead - fiddling around with it the way you do
>> only asks for trouble in the future.
>>
>> What we need are two different variables for:
>> - hyperthreading and
>> - multicore
>
> He does, and calls them SCHED_SMT and SCHED_MC respectively.
These are the already existing scheduler related variables that are
only a part of the X86_HT usages.
> It's not particularly clear to me what X86_HT is meant to be used for
> anymore at all.
grep through the source code and you find it is sometimes used for
hyperthreading and sometimes for multicore.
I don't care whether X86_HT gets splitted or perhaps even removed, but
any change to it should remove the status quo of it having two different
semantics.
> -hpa
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
next prev parent reply other threads:[~2008-02-27 21:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 21:16 Hiroshi Shimamoto
2008-02-27 21:26 ` Adrian Bunk
2008-02-27 21:30 ` H. Peter Anvin
2008-02-27 21:58 ` Adrian Bunk [this message]
2008-02-27 22:16 ` Hiroshi Shimamoto
2008-02-27 22:37 ` Adrian Bunk
2008-02-27 22:00 ` Yinghai Lu
2008-02-27 22:31 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080227215816.GX29269@cs181133002.pp.htv.fi \
--to=bunk@kernel.org \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®