From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "H. Peter Anvin" <hpa@zytor.com>
Cc: "Adrian Bunk" <bunk@kernel.org>,
"Hiroshi Shimamoto" <h-shimamoto@ct.jp.nec.com>,
"Ingo Molnar" <mingo@elte.hu>,
"Thomas Gleixner" <tglx@linutronix.de>,
"Sam Ravnborg" <sam@ravnborg.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86: X86_HT always enable on X86_64 SMP
Date: Wed, 27 Feb 2008 14:00:01 -0800 [thread overview]
Message-ID: <86802c440802271400k5e981d40vfd278c07c6bf04f5@mail.gmail.com> (raw)
In-Reply-To: <47C5D693.3030207@zytor.com>
On Wed, Feb 27, 2008 at 1:30 PM, H. Peter Anvin <hpa@zytor.com> wrote:
> Adrian Bunk wrote:
> > On Wed, Feb 27, 2008 at 01:16:30PM -0800, Hiroshi Shimamoto wrote:
> >> From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com>
> >>
> >> X86_HT is used for hyperthreading or multicore on 32-bit.
> >> The X86_HT on 64-bit is different from 32-bit, it means hyperthreading only.
> >> And X86_HT is not used on 64-bit except from cpu/initel_cacheinfo.c.
> >>
> >> Unify X86_HT for hyperthreading or multicore.
> >> Turn X86_HT on when X86_64 and SMP are enabled.
> >
> > Please fix it properly instead - fiddling around with it the way you do
> > only asks for trouble in the future.
> >
> > What we need are two different variables for:
> > - hyperthreading and
> > - multicore
> >
>
> He does, and calls them SCHED_SMT and SCHED_MC respectively.
>
> It's not particularly clear to me what X86_HT is meant to be used for
> anymore at all.
he made X86_HT can be enabled when only Opteron supported is enabled.
it should be stated in the comments.
YH
next prev parent reply other threads:[~2008-02-27 22:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-02-27 21:16 Hiroshi Shimamoto
2008-02-27 21:26 ` Adrian Bunk
2008-02-27 21:30 ` H. Peter Anvin
2008-02-27 21:58 ` Adrian Bunk
2008-02-27 22:16 ` Hiroshi Shimamoto
2008-02-27 22:37 ` Adrian Bunk
2008-02-27 22:00 ` Yinghai Lu [this message]
2008-02-27 22:31 ` Hiroshi Shimamoto
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=86802c440802271400k5e981d40vfd278c07c6bf04f5@mail.gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=bunk@kernel.org \
--cc=h-shimamoto@ct.jp.nec.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sam@ravnborg.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®