Re: 2.6.25-rc3-mm1 (CCISS)

[Jens Axboe <jens.axboe@oracle.com>]

On Tue, Mar 04 2008, Randy Dunlap wrote:
> Miller, Mike (OS Dev) wrote:
> >Randy wrote:
> >>On Tue, 4 Mar 2008 01:19:28 -0800 Andrew Morton wrote:
> >>
> >>>
> >>ftp://ftp.kernel.org/pub/linux/kernel/people/akpm/patches/2.6/2.6.25-r
> >>>c3/2.6.25-rc3-mm1/
> >>With
> >>CONFIG_BLK_CPQ_DA=m
> >>CONFIG_BLK_CPQ_CISS_DA=m
> >># CONFIG_CISS_SCSI_TAPE is not set
> >>
> >>I'm getting
> >>In file included from drivers/block/cciss.c:230:
> >>drivers/block/cciss_scsi.c:1498:38: error: macro parameters
> >>must be comma-separated
> >>drivers/block/cciss.c: In function 'cciss_seq_show_header':
> >>drivers/block/cciss.c:271: error: implicit declaration of
> >>function 'cciss_seq_tape_report'
> >>drivers/block/cciss.c: In function 'cciss_proc_write':
> >>drivers/block/cciss.c:392: error: implicit declaration of
> >>function 'cciss_engage_scsi'
> >>make[2]: *** [drivers/block/cciss.o] Error 1
> >>make[1]: *** [drivers/block] Error 2
> >>make[1]: *** Waiting for unfinished jobs....
> >>
> >>---
> >Randy,
> >It looks like you have the original broken patch. I resubmitted and I 
> >think Jens picked up the fixed patch but I don't know where it is...  :(
> 
> s/you/latest -mm/
> 
> I thought that this had been fixed, but I can't find it either... :(
> 
> Jens, did you queue a patch for this?

I did, here:

http://git.kernel.dk/?p=linux-2.6-block.git;a=commit;h=89b6e743788516491846724d7ef89bcac7ac9c99

-- 
Jens Axboe